From: "Krzysztof Wilczyński" <kw@linux.com>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Alistair Francis <alistair@alistair23.me>,
marek.vasut+renesas@gmail.com, yoshihiro.shimoda.uh@renesas.com,
linux-pci@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, lpieralisi@kernel.org,
robh@kernel.org, bhelgaas@google.com, alistair23@gmail.com
Subject: Re: [PATCH] PCI: rcar-ep: Include linux/pci-epf.h instead of linux/pci-epc.h
Date: Wed, 5 Jul 2023 20:44:43 +0900 [thread overview]
Message-ID: <20230705114443.GA3555378@rocinante> (raw)
In-Reply-To: <7536d9a3-4738-2bc2-e33e-d93347893865@kernel.org>
Hello,
> > pci-epc.h doesn't define the members of the pci_epf_header struct, so
> > trying to access them results in errors like this:
> >
> > error: invalid use of undefined type 'struct pci_epf_header'
> > 167 | val = hdr->vendorid;
> >
> > Instead let's include pci-epf.h which not only defines the
> > pci_epf_header but also includes pci-epc.h.
[...]
> It is odd that the the build bot did not detect this...
This is a bit of a surprise to me too, especially since none of the usual
bots pick this up, and I can't seem to find such a failure in the nightly
CI logs either.
Alistair, how did you stumble into this issue? Also, which version or
a tree would that be?
Thank you!
Krzysztof
next prev parent reply other threads:[~2023-07-05 11:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-05 10:48 [PATCH] PCI: rcar-ep: Include linux/pci-epf.h instead of linux/pci-epc.h Alistair Francis
2023-07-05 11:10 ` Damien Le Moal
2023-07-05 11:44 ` Krzysztof Wilczyński [this message]
2023-07-05 11:57 ` Alistair Francis
2023-07-05 13:15 ` Krzysztof Wilczyński
2023-07-05 21:53 ` Damien Le Moal
2023-07-06 1:44 ` Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230705114443.GA3555378@rocinante \
--to=kw@linux.com \
--cc=alistair23@gmail.com \
--cc=alistair@alistair23.me \
--cc=bhelgaas@google.com \
--cc=dlemoal@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=robh@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox