From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EDFBEB64D9 for ; Thu, 6 Jul 2023 03:51:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232084AbjGFDvp (ORCPT ); Wed, 5 Jul 2023 23:51:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231868AbjGFDvm (ORCPT ); Wed, 5 Jul 2023 23:51:42 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 040951BD3; Wed, 5 Jul 2023 20:51:40 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id F0BE3807E; Thu, 6 Jul 2023 03:51:39 +0000 (UTC) Date: Thu, 6 Jul 2023 06:51:38 +0300 From: Tony Lindgren To: Julien Panis Cc: Roger Quadros , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, vigneshr@ti.com, nm@ti.com, Tom Rini Subject: Re: [PATCH 0/3] Configure usb0 as peripheral on am335x boards Message-ID: <20230706035138.GA5089@atomide.com> References: <20230629-usb0-as-peripheral-v1-0-167f78a11746@baylibre.com> <20230630072047.GK14287@atomide.com> <7f44798b-e2bf-1620-da37-ca13bfd07a21@kernel.org> <9ef45899-c766-e839-522a-3b048f8106f7@kernel.org> <6a51d860-2d20-6c35-3935-985d5b41853e@baylibre.com> <73a4545a-e149-261a-a0c5-a526e8740bd5@kernel.org> <6d485ee7-9b8a-626e-da8a-bbff37bcde61@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6d485ee7-9b8a-626e-da8a-bbff37bcde61@baylibre.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, * Julien Panis [230703 15:51]: > OK. In other words, we just need to reconsider my previous u-boot series. :-) > I was setting usb0 as 'peripheral' in 'am335x-*-u-boot.dts' here: > https://lore.kernel.org/all/20230621-fix_usb_ether_init-v2-0-ff121f0e8d7a@baylibre.com/ It would be best to not change the dts as it's describing the hardware capabilities. Instead, it would be better to parse the capability in the driver to handle a dual-role wired usb-ab connector as peripheral only in u-boot. Regards, Tony