From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7C94C001DF for ; Thu, 6 Jul 2023 11:12:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232194AbjGFLMj (ORCPT ); Thu, 6 Jul 2023 07:12:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229519AbjGFLMh (ORCPT ); Thu, 6 Jul 2023 07:12:37 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2566DDC; Thu, 6 Jul 2023 04:12:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B7B0661909; Thu, 6 Jul 2023 11:12:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DDADC433C7; Thu, 6 Jul 2023 11:12:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688641956; bh=BOEale8M+9gWzJpHRuHXhPnvc4ZSy1w4GTYANy5u44s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kMxNh/3WZijIVGdc5yewDH3XOYZUJwECrYRcBFuLMNQ6IMO+jdsuY6d6UiK1oWhZx vMdet9znENk+RtaQZfEztdHqN1uut3JpGzkFSI17xYpbcX9RGgw2PRiKI6uIpZzhiD bfXQOzUbhI3UcUlU/v5fz+mIBTxc1EsVRivVIoHifcmzkQOKhmmSOCFTWXj2rErFBW 34/4SE/+Sre/Kam6uvCMHHDa4TYCH4ggFSZNAdXJGALxdDqTG1dYhsdXobgKbupeEz GOJ/uscUFvn5ndcc75HnJ4G3BMHCYZETHEzWtfVBiu1RYhJbcrzcigPlpj37ufzAWg PSSkAfs7Wg0PQ== Date: Thu, 6 Jul 2023 16:42:18 +0530 From: Manivannan Sadhasivam To: Krzysztof Kozlowski Cc: Manivannan Sadhasivam , Mrinmay Sarkar , agross@kernel.org, andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, konrad.dybcio@linaro.org, quic_shazhuss@quicinc.com, quic_nitegupt@quicinc.com, quic_ramkri@quicinc.com, quic_nayiluri@quicinc.com, Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Vinod Koul , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org Subject: Re: [PATCH v1 0/6] arm64: qcom: sa8775p: add support for PCIe Message-ID: <20230706111218.GA4808@thinkpad> References: <1688545032-17748-1-git-send-email-quic_msarkar@quicinc.com> <20230705084606.GF11854@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 06, 2023 at 08:39:54AM +0200, Krzysztof Kozlowski wrote: > On 05/07/2023 10:46, Manivannan Sadhasivam wrote: > > On Wed, Jul 05, 2023 at 01:47:05PM +0530, Mrinmay Sarkar wrote: > >> Update the relavent DT bindings for PCIe, add new config to the phy > >> driver add pcie and phy nodes to the .dtsi file and enable then in > >> board .dts file for the sa8775p-ride platform. > >> > >> Mrinmay Sarkar (6): > >> dt-bindings: PCI: qcom: Add sa8775p compatible > >> dt-bindings: phy: qcom,qmp: Add sa8775p QMP PCIe PHY > >> PCI: qcom: Add support for sa8775p SoC > >> phy: qcom-qmp-pcie: add support for sa8775p > >> arm64: dts: qcom: sa8775p: Add pcie0 and pcie1 nodes > >> arm64: dts: qcom: sa8775p-ride: enable pcie nodes > > > > Please note that the dts patches should come before driver patches. > > > > Why? DTS is always independent thus usually put at the end of patchset > or better separate. It is the first time I hear that DTS should be > before driver. > This is what I was suggested by Rob during my initial days and I've been following this pattern since then. If that's not the case, I have no issues. - Mani > Best regards, > Krzysztof > -- மணிவண்ணன் சதாசிவம்