From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84B4DEB64DD for ; Thu, 6 Jul 2023 13:09:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232313AbjGFNJU (ORCPT ); Thu, 6 Jul 2023 09:09:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229490AbjGFNJT (ORCPT ); Thu, 6 Jul 2023 09:09:19 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EA4E1BE9; Thu, 6 Jul 2023 06:09:01 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 89D8067373; Thu, 6 Jul 2023 15:08:58 +0200 (CEST) Date: Thu, 6 Jul 2023 15:08:58 +0200 From: Christoph Hellwig To: chengming.zhou@linux.dev Cc: axboe@kernel.dk, ming.lei@redhat.com, hch@lst.de, tj@kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Chengming Zhou Subject: Re: [PATCH v2 4/4] blk-mq: delete unused completion_data in struct request Message-ID: <20230706130858.GD13089@lst.de> References: <20230629110359.1111832-1-chengming.zhou@linux.dev> <20230629110359.1111832-5-chengming.zhou@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230629110359.1111832-5-chengming.zhou@linux.dev> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Looks good: Reviewed-by: Christoph Hellwig Although I'd order it first or even send it separately as it doesn't need any of the other changes.