From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Yangtao Li <frank.li@vivo.com>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/18] drm/renesas: Convert to devm_platform_ioremap_resource()
Date: Fri, 7 Jul 2023 11:33:29 +0300 [thread overview]
Message-ID: <20230707083329.GA16622@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20230707072034.48977-1-frank.li@vivo.com>
Hi Yangtao,
Thank you for the patch.
On Fri, Jul 07, 2023 at 03:20:17PM +0800, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c b/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c
> index e10e4d4b89a2..4bf9f5d15fa8 100644
> --- a/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c
> +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_mipi_dsi.c
> @@ -1002,7 +1002,6 @@ static int rcar_mipi_dsi_get_clocks(struct rcar_mipi_dsi *dsi)
> static int rcar_mipi_dsi_probe(struct platform_device *pdev)
> {
> struct rcar_mipi_dsi *dsi;
> - struct resource *mem;
> int ret;
>
> dsi = devm_kzalloc(&pdev->dev, sizeof(*dsi), GFP_KERNEL);
> @@ -1019,8 +1018,7 @@ static int rcar_mipi_dsi_probe(struct platform_device *pdev)
> return ret;
>
> /* Acquire resources. */
> - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - dsi->mmio = devm_ioremap_resource(dsi->dev, mem);
> + dsi->mmio = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(dsi->mmio))
> return PTR_ERR(dsi->mmio);
>
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2023-07-07 8:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 7:20 [PATCH 01/18] drm/renesas: Convert to devm_platform_ioremap_resource() Yangtao Li
2023-07-07 7:20 ` [PATCH 02/18] gpu: ipu-v3: pre: " Yangtao Li
2023-07-07 8:20 ` Philipp Zabel
2023-07-07 7:20 ` [PATCH 03/18] drm/rockchip: dsi: Use devm_platform_get_and_ioremap_resource() Yangtao Li
2023-07-07 7:20 ` [PATCH 04/18] drm: kirin: Convert to devm_platform_ioremap_resource() Yangtao Li
2023-07-07 7:20 ` [PATCH 05/18] drm/tegra: hdmi: " Yangtao Li
2023-07-07 7:20 ` [PATCH 06/18] drm: bridge: dw_hdmi: Use devm_platform_get_and_ioremap_resource() Yangtao Li
2023-07-07 7:27 ` Neil Armstrong
2023-07-07 7:20 ` [PATCH 07/18] drm/bridge: analogix_dp: Convert to devm_platform_ioremap_resource() Yangtao Li
2023-07-07 7:27 ` Neil Armstrong
2023-07-07 7:20 ` [PATCH 08/18] gpu: ipu-v3: prg: " Yangtao Li
2023-07-07 8:20 ` Philipp Zabel
2023-07-07 7:20 ` [PATCH 09/18] drm/hisilicon: " Yangtao Li
2023-07-07 7:20 ` [PATCH 10/18] drm: lcdif: " Yangtao Li
2023-07-07 7:20 ` [PATCH 11/18] drm/mxsfb: " Yangtao Li
2023-07-07 7:20 ` [PATCH 12/18] drm/tegra: dpaux: " Yangtao Li
2023-07-07 12:28 ` Thierry Reding
2023-07-07 7:20 ` [PATCH 13/18] drm/stm: ltdc: " Yangtao Li
2023-07-07 13:37 ` Raphael Gallais-Pou
2023-07-07 7:20 ` [PATCH 14/18] drm/aspeed: " Yangtao Li
2023-07-07 7:20 ` [PATCH 15/18] drm/tegra: sor: " Yangtao Li
2023-07-07 7:20 ` [PATCH 16/18] drm/rockchip: vop: Use devm_platform_get_and_ioremap_resource() Yangtao Li
2023-07-07 7:20 ` [PATCH 17/18] drm/arcpgu: Convert to devm_platform_ioremap_resource() Yangtao Li
2023-07-07 13:24 ` Alexey Brodkin
2023-07-07 7:20 ` [PATCH 18/18] drm/fsl-dcu: " Yangtao Li
2023-07-07 8:33 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230707083329.GA16622@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=frank.li@vivo.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox