From: chengming.zhou@linux.dev
To: axboe@kernel.dk, ming.lei@redhat.com, hch@lst.de, tj@kernel.org
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
zhouchengming@bytedance.com
Subject: [PATCH v3 0/4] blk-mq: optimize the size of struct request
Date: Fri, 7 Jul 2023 17:37:18 +0800 [thread overview]
Message-ID: <20230707093722.1338589-1-chengming.zhou@linux.dev> (raw)
From: Chengming Zhou <zhouchengming@bytedance.com>
v3:
- Collect Reviewed-by tags from Ming and Christoph. Thanks!
- Remove the list and csd variables which are only used once.
- Fix a bug report of blktests nvme/012 by re-initialization of
rq->queuelist, which maybe corrupted by rq->rq_next reuse.
- [v2] https://lore.kernel.org/all/20230629110359.1111832-1-chengming.zhou@linux.dev/
v2:
- Change to use call_single_data_t, which use __aligned() to avoid
to use 2 cache lines for 1 csd. Thanks Ming Lei.
- [v1] https://lore.kernel.org/all/20230627120854.971475-1-chengming.zhou@linux.dev/
Hello,
After the commit be4c427809b0 ("blk-mq: use the I/O scheduler for
writes from the flush state machine"), rq->flush can't reuse rq->elv
anymore, since flush_data requests can go into io scheduler now.
That increased the size of struct request by 24 bytes, but this
patchset can decrease the size by 40 bytes, which is good I think.
patch 1 is just cleanup by the way.
patch 2 use percpu csd to do remote complete instead of per-rq csd,
decrease the size by 24 bytes.
patch 3-4 reuse rq->queuelist in flush state machine pending list,
and maintain unsigned long counter of inflight flush_data requests,
decrease the size by 16 bytes.
Thanks for comments!
Chengming Zhou (4):
blk-mq: delete unused completion_data in struct request
blk-mq: use percpu csd to remote complete instead of per-rq csd
blk-flush: count inflight flush_data requests
blk-flush: reuse rq queuelist in flush state machine
block/blk-flush.c | 24 ++++++++++++++----------
block/blk-mq.c | 12 ++++++------
block/blk.h | 5 ++---
include/linux/blk-mq.h | 10 ++--------
4 files changed, 24 insertions(+), 27 deletions(-)
--
2.41.0
next reply other threads:[~2023-07-07 9:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 9:37 chengming.zhou [this message]
2023-07-07 9:37 ` [PATCH v3 1/4] blk-mq: delete unused completion_data in struct request chengming.zhou
2023-07-07 10:05 ` Ming Lei
2023-07-07 9:37 ` [PATCH v3 2/4] blk-mq: use percpu csd to remote complete instead of per-rq csd chengming.zhou
2023-07-10 6:42 ` Christoph Hellwig
2023-07-07 9:37 ` [PATCH v3 3/4] blk-flush: count inflight flush_data requests chengming.zhou
2023-07-07 9:37 ` [PATCH v3 4/4] blk-flush: reuse rq queuelist in flush state machine chengming.zhou
2023-07-07 10:06 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230707093722.1338589-1-chengming.zhou@linux.dev \
--to=chengming.zhou@linux.dev \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=tj@kernel.org \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox