From: Jakub Kicinski <kuba@kernel.org>
To: Justin Forbes <jforbes@fedoraproject.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
jmforbes@linuxtx.org
Subject: Re: [PATCH] Move rmnet out of NET_VENDOR_QUALCOMM dependency
Date: Fri, 7 Jul 2023 15:12:06 -0700 [thread overview]
Message-ID: <20230707151206.137d3a94@kernel.org> (raw)
In-Reply-To: <CAFbkSA0wW-tQ_b_GF3z2JqtO4hc0c+1gcbcyTcgjYbQBsEYLyA@mail.gmail.com>
On Fri, 7 Jul 2023 11:50:16 -0500 Justin Forbes wrote:
> > On Thu, 6 Jul 2023 09:51:52 -0500 Justin M. Forbes wrote:
> > > The rmnet driver is useful for chipsets that are not hidden behind
> > > NET_VENDOR_QUALCOMM. Move sourcing the rmnet Kconfig outside of the if
> > > NET_VENDOR_QUALCOMM as there is no dependency here.
> > >
> > > Signed-off-by: Justin M. Forbes <jforbes@fedoraproject.org>
> >
> > Examples of the chipsets you're talking about would be great to have in
> > the commit message.
>
> The user in the Fedora bug was using mhi_net with qmi_wwan.
Hm, if anything mhi_net should not be sitting directly in drivers/net/
I don't think this is a change in the right direction, just enable
VENDOR_QUALCOMM? Or am I missing something?
next prev parent reply other threads:[~2023-07-07 22:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 14:51 [PATCH] Move rmnet out of NET_VENDOR_QUALCOMM dependency Justin M. Forbes
2023-07-06 15:44 ` Jakub Kicinski
2023-07-07 16:50 ` Justin Forbes
2023-07-07 22:12 ` Jakub Kicinski [this message]
2023-07-07 23:19 ` Justin Forbes
2023-07-07 23:27 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230707151206.137d3a94@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jforbes@fedoraproject.org \
--cc=jmforbes@linuxtx.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox