From: Jakub Kicinski <kuba@kernel.org>
To: Justin Forbes <jforbes@fedoraproject.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Move rmnet out of NET_VENDOR_QUALCOMM dependency
Date: Fri, 7 Jul 2023 16:27:37 -0700 [thread overview]
Message-ID: <20230707162737.0a411b18@kernel.org> (raw)
In-Reply-To: <CAFxkdApnEo8RPOQ3zVjAZBeTtH2UbaT2798gQ5w0SA5e-dtZng@mail.gmail.com>
On Fri, 7 Jul 2023 17:19:12 -0600 Justin Forbes wrote:
> they add an entry for it, and don't realize that the entry is ignored
Maybe that someone should not be "adding an entry" to a file which
has this at the top:
#
# Automatically generated file; DO NOT EDIT.
?
> VENDOR_QUALCOMM is not enabled. Either all devices capable of using
> rmnet should be hidden behind VENDOR_QUALCOMM or rmnet should not be.
I agree that Qualcomm drivers are an atrocious mess.
They should live neatly in the wwan section. But it's Qualcomm,
they don't care. Let's not have it sprawl even more.
prev parent reply other threads:[~2023-07-07 23:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 14:51 [PATCH] Move rmnet out of NET_VENDOR_QUALCOMM dependency Justin M. Forbes
2023-07-06 15:44 ` Jakub Kicinski
2023-07-07 16:50 ` Justin Forbes
2023-07-07 22:12 ` Jakub Kicinski
2023-07-07 23:19 ` Justin Forbes
2023-07-07 23:27 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230707162737.0a411b18@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jforbes@fedoraproject.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox