From: Jakub Kicinski <kuba@kernel.org>
To: Alexandru Gagniuc <alexandru.gagniuc@hp.com>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
hayeswang@realtek.com, jflf_kernel@gmx.com, bjorn@mork.no,
svenva@chromium.org, linux-kernel@vger.kernel.org,
eniac-xw.zhang@hp.com, stable@vger.kernel.org
Subject: Re: [PATCH] r8152: Suspend USB device before shutdown when WoL is enabled
Date: Fri, 7 Jul 2023 17:12:25 -0700 [thread overview]
Message-ID: <20230707171225.3cb6e354@kernel.org> (raw)
In-Reply-To: <20230706182858.761311-1-alexandru.gagniuc@hp.com>
On Thu, 6 Jul 2023 18:28:58 +0000 Alexandru Gagniuc wrote:
> For Wake-on-LAN to work from S5 (shutdown), the USB link must be put
> in U3 state. If it is not, and the host "disappears", the chip will
> no longer respond to WoL triggers.
>
> To resolve this, add a notifier block and register it as a reboot
> notifier. When WoL is enabled, work through the usb_device struct to
> get to the suspend function. Calling this function puts the link in
> the correct state for WoL to function.
Would be good to hear from USB experts on this one, to an outside seems
like something that the bus should be doing, possibly based on some
driver opt-in..
> Cc: stable@vger.kernel.org
> Signed-off-by: Alexandru Gagniuc <alexandru.gagniuc@hp.com>
Please add a Fixes tag - I'm guessing it dates back to
Fixes: 21ff2e8976b1 ("r8152: support WOL")
?
--
pw-bot: cr
next prev parent reply other threads:[~2023-07-08 0:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 18:28 [PATCH] r8152: Suspend USB device before shutdown when WoL is enabled Alexandru Gagniuc
2023-07-08 0:12 ` Jakub Kicinski [this message]
2023-07-08 1:51 ` Alan Stern
2023-07-19 17:37 ` [PATCH v2] " Alexandru Gagniuc
2023-07-19 18:36 ` Alan Stern
2023-08-02 14:56 ` Gagniuc, Alexandru
2023-08-02 15:23 ` Alan Stern
2023-08-10 16:22 ` Alexandru Gagniuc
2023-08-10 17:34 ` Alan Stern
2023-08-10 22:51 ` Alexandru Gagniuc
2023-08-11 1:51 ` Alan Stern
2023-07-20 8:39 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230707171225.3cb6e354@kernel.org \
--to=kuba@kernel.org \
--cc=alexandru.gagniuc@hp.com \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eniac-xw.zhang@hp.com \
--cc=hayeswang@realtek.com \
--cc=jflf_kernel@gmx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=svenva@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox