* arch/sh/boards/mach-hp6xx/hp6xx_apm.c:32:22: warning: variable 'backup' set but not used
@ 2023-07-07 19:40 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2023-07-07 19:40 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: oe-kbuild-all, linux-kernel, John Paul Adrian Glaubitz
Hi Masahiro,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 4f6b6c2b2f86b7878a770736bf478d8a263ff0bc
commit: 706afcea16cd83fecb7c2229ccc31bb237ffdbef sh: Fix -Wmissing-include-dirs warnings for various platforms
date: 2 days ago
config: sh-hp6xx_defconfig (https://download.01.org/0day-ci/archive/20230708/202307080311.ZgsVj2PR-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230708/202307080311.ZgsVj2PR-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307080311.ZgsVj2PR-lkp@intel.com/
All warnings (new ones prefixed by >>):
arch/sh/boards/mach-hp6xx/hp6xx_apm.c: In function 'hp6x0_apm_get_power_status':
>> arch/sh/boards/mach-hp6xx/hp6xx_apm.c:32:22: warning: variable 'backup' set but not used [-Wunused-but-set-variable]
32 | int battery, backup, charging, percentage;
| ^~~~~~
vim +/backup +32 arch/sh/boards/mach-hp6xx/hp6xx_apm.c
dd4f99b42dcce8 arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2008-03-06 29
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 30 static void hp6x0_apm_get_power_status(struct apm_power_info *info)
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 31 {
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 @32 int battery, backup, charging, percentage;
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 33 u8 pgdr;
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 34
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 35 battery = adc_single(ADC_CHANNEL_BATTERY);
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 36 backup = adc_single(ADC_CHANNEL_BACKUP);
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 37 charging = adc_single(ADC_CHANNEL_CHARGE);
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 38
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 39 percentage = 100 * (battery - HP680_BATTERY_MIN) /
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 40 (HP680_BATTERY_MAX - HP680_BATTERY_MIN);
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 41
8b03c040e4efaa arch/sh/boards/hp6xx/hp6xx_apm.c Kristoffer Ericson 2008-03-04 42 /* % of full battery */
8b03c040e4efaa arch/sh/boards/hp6xx/hp6xx_apm.c Kristoffer Ericson 2008-03-04 43 info->battery_life = percentage;
8b03c040e4efaa arch/sh/boards/hp6xx/hp6xx_apm.c Kristoffer Ericson 2008-03-04 44
8b03c040e4efaa arch/sh/boards/hp6xx/hp6xx_apm.c Kristoffer Ericson 2008-03-04 45 /* We want our estimates in minutes */
8b03c040e4efaa arch/sh/boards/hp6xx/hp6xx_apm.c Kristoffer Ericson 2008-03-04 46 info->units = 0;
8b03c040e4efaa arch/sh/boards/hp6xx/hp6xx_apm.c Kristoffer Ericson 2008-03-04 47
8b03c040e4efaa arch/sh/boards/hp6xx/hp6xx_apm.c Kristoffer Ericson 2008-03-04 48 /* Extremely(!!) rough estimate, we will replace this with a datalist later on */
8b03c040e4efaa arch/sh/boards/hp6xx/hp6xx_apm.c Kristoffer Ericson 2008-03-04 49 info->time = (2 * battery);
8b03c040e4efaa arch/sh/boards/hp6xx/hp6xx_apm.c Kristoffer Ericson 2008-03-04 50
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 51 info->ac_line_status = (battery > HP680_BATTERY_AC_ON) ?
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 52 APM_AC_ONLINE : APM_AC_OFFLINE;
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 53
9d56dd3b083a3b arch/sh/boards/mach-hp6xx/hp6xx_apm.c Paul Mundt 2010-01-26 54 pgdr = __raw_readb(PGDR);
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 55 if (pgdr & PGDR_MAIN_BATTERY_OUT) {
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 56 info->battery_status = APM_BATTERY_STATUS_NOT_PRESENT;
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 57 info->battery_flag = 0x80;
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 58 } else if (charging < 8) {
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 59 info->battery_status = APM_BATTERY_STATUS_CHARGING;
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 60 info->battery_flag = 0x08;
8b03c040e4efaa arch/sh/boards/hp6xx/hp6xx_apm.c Kristoffer Ericson 2008-03-04 61 info->ac_line_status = 0x01;
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 62 } else if (percentage <= APM_CRITICAL) {
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 63 info->battery_status = APM_BATTERY_STATUS_CRITICAL;
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 64 info->battery_flag = 0x04;
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 65 } else if (percentage <= APM_LOW) {
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 66 info->battery_status = APM_BATTERY_STATUS_LOW;
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 67 info->battery_flag = 0x02;
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 68 } else {
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 69 info->battery_status = APM_BATTERY_STATUS_HIGH;
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 70 info->battery_flag = 0x01;
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 71 }
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 72 }
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 73
:::::: The code at line 32 was first introduced by commit
:::::: 0a9b0db19262dbb09f3a34195e68cafd5dc3fa10 [APM] SH: Convert to use shared APM emulation.
:::::: TO: Paul Mundt <lethal@linux-sh.org>
:::::: CC: Ralf Baechle <ralf@linux-mips.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* arch/sh/boards/mach-hp6xx/hp6xx_apm.c:32:22: warning: variable 'backup' set but not used
@ 2023-11-02 8:42 kernel test robot
2023-11-02 8:50 ` John Paul Adrian Glaubitz
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2023-11-02 8:42 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: oe-kbuild-all, linux-kernel, John Paul Adrian Glaubitz
Hi Masahiro,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 21e80f3841c01aeaf32d7aee7bbc87b3db1aa0c6
commit: 706afcea16cd83fecb7c2229ccc31bb237ffdbef sh: Fix -Wmissing-include-dirs warnings for various platforms
date: 4 months ago
config: sh-hp6xx_defconfig (https://download.01.org/0day-ci/archive/20231102/202311021607.1gLwwwRL-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231102/202311021607.1gLwwwRL-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311021607.1gLwwwRL-lkp@intel.com/
All warnings (new ones prefixed by >>):
arch/sh/boards/mach-hp6xx/hp6xx_apm.c: In function 'hp6x0_apm_get_power_status':
>> arch/sh/boards/mach-hp6xx/hp6xx_apm.c:32:22: warning: variable 'backup' set but not used [-Wunused-but-set-variable]
32 | int battery, backup, charging, percentage;
| ^~~~~~
vim +/backup +32 arch/sh/boards/mach-hp6xx/hp6xx_apm.c
dd4f99b42dcce8 arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2008-03-06 29
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 30 static void hp6x0_apm_get_power_status(struct apm_power_info *info)
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 31 {
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 @32 int battery, backup, charging, percentage;
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 33 u8 pgdr;
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 34
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 35 battery = adc_single(ADC_CHANNEL_BATTERY);
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 36 backup = adc_single(ADC_CHANNEL_BACKUP);
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 37 charging = adc_single(ADC_CHANNEL_CHARGE);
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 38
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 39 percentage = 100 * (battery - HP680_BATTERY_MIN) /
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 40 (HP680_BATTERY_MAX - HP680_BATTERY_MIN);
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 41
8b03c040e4efaa arch/sh/boards/hp6xx/hp6xx_apm.c Kristoffer Ericson 2008-03-04 42 /* % of full battery */
8b03c040e4efaa arch/sh/boards/hp6xx/hp6xx_apm.c Kristoffer Ericson 2008-03-04 43 info->battery_life = percentage;
8b03c040e4efaa arch/sh/boards/hp6xx/hp6xx_apm.c Kristoffer Ericson 2008-03-04 44
8b03c040e4efaa arch/sh/boards/hp6xx/hp6xx_apm.c Kristoffer Ericson 2008-03-04 45 /* We want our estimates in minutes */
8b03c040e4efaa arch/sh/boards/hp6xx/hp6xx_apm.c Kristoffer Ericson 2008-03-04 46 info->units = 0;
8b03c040e4efaa arch/sh/boards/hp6xx/hp6xx_apm.c Kristoffer Ericson 2008-03-04 47
8b03c040e4efaa arch/sh/boards/hp6xx/hp6xx_apm.c Kristoffer Ericson 2008-03-04 48 /* Extremely(!!) rough estimate, we will replace this with a datalist later on */
8b03c040e4efaa arch/sh/boards/hp6xx/hp6xx_apm.c Kristoffer Ericson 2008-03-04 49 info->time = (2 * battery);
8b03c040e4efaa arch/sh/boards/hp6xx/hp6xx_apm.c Kristoffer Ericson 2008-03-04 50
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 51 info->ac_line_status = (battery > HP680_BATTERY_AC_ON) ?
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 52 APM_AC_ONLINE : APM_AC_OFFLINE;
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 53
9d56dd3b083a3b arch/sh/boards/mach-hp6xx/hp6xx_apm.c Paul Mundt 2010-01-26 54 pgdr = __raw_readb(PGDR);
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 55 if (pgdr & PGDR_MAIN_BATTERY_OUT) {
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 56 info->battery_status = APM_BATTERY_STATUS_NOT_PRESENT;
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 57 info->battery_flag = 0x80;
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 58 } else if (charging < 8) {
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 59 info->battery_status = APM_BATTERY_STATUS_CHARGING;
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 60 info->battery_flag = 0x08;
8b03c040e4efaa arch/sh/boards/hp6xx/hp6xx_apm.c Kristoffer Ericson 2008-03-04 61 info->ac_line_status = 0x01;
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 62 } else if (percentage <= APM_CRITICAL) {
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 63 info->battery_status = APM_BATTERY_STATUS_CRITICAL;
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 64 info->battery_flag = 0x04;
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 65 } else if (percentage <= APM_LOW) {
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 66 info->battery_status = APM_BATTERY_STATUS_LOW;
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 67 info->battery_flag = 0x02;
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 68 } else {
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 69 info->battery_status = APM_BATTERY_STATUS_HIGH;
0a9b0db19262db arch/sh/boards/hp6xx/hp6xx_apm.c Paul Mundt 2007-01-24 70 info->battery_flag = 0x01;
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 71 }
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 72 }
3aa770e7972723 arch/sh/boards/hp6xx/hp6xx_apm.c Andriy Skulysh 2006-09-27 73
:::::: The code at line 32 was first introduced by commit
:::::: 0a9b0db19262dbb09f3a34195e68cafd5dc3fa10 [APM] SH: Convert to use shared APM emulation.
:::::: TO: Paul Mundt <lethal@linux-sh.org>
:::::: CC: Ralf Baechle <ralf@linux-mips.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: arch/sh/boards/mach-hp6xx/hp6xx_apm.c:32:22: warning: variable 'backup' set but not used
2023-11-02 8:42 kernel test robot
@ 2023-11-02 8:50 ` John Paul Adrian Glaubitz
0 siblings, 0 replies; 3+ messages in thread
From: John Paul Adrian Glaubitz @ 2023-11-02 8:50 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: oe-kbuild-all, linux-kernel, Geert Uytterhoeven, linux-sh
Hi Masahiro,
On Thu, 2023-11-02 at 16:42 +0800, kernel test robot wrote:
> FYI, the error/warning still remains.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 21e80f3841c01aeaf32d7aee7bbc87b3db1aa0c6
> commit: 706afcea16cd83fecb7c2229ccc31bb237ffdbef sh: Fix -Wmissing-include-dirs warnings for various platforms
> date: 4 months ago
> config: sh-hp6xx_defconfig (https://download.01.org/0day-ci/archive/20231102/202311021607.1gLwwwRL-lkp@intel.com/config)
> compiler: sh4-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231102/202311021607.1gLwwwRL-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202311021607.1gLwwwRL-lkp@intel.com/
Was there a patch posted to fix this?
I will review your other patch today and send a PR to Linus later.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-02 8:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-07 19:40 arch/sh/boards/mach-hp6xx/hp6xx_apm.c:32:22: warning: variable 'backup' set but not used kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2023-11-02 8:42 kernel test robot
2023-11-02 8:50 ` John Paul Adrian Glaubitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox