From: Andrew Morton <akpm@linux-foundation.org>
To: Raul E Rangel <rrangel@chromium.org>
Cc: linux-kernel@vger.kernel.org, mario.limonciello@amd.com,
kramasub@chromium.org, Alexander Potapenko <glider@google.com>,
Ard Biesheuvel <ardb@kernel.org>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Li Zhe <lizhe.67@bytedance.com>,
"Liam R. Howlett" <Liam.Howlett@Oracle.com>,
Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Zhou jie <zhoujie@nfschina.com>
Subject: Re: [PATCH] init: Don't proxy console= to earlycon
Date: Sat, 8 Jul 2023 17:48:32 -0700 [thread overview]
Message-ID: <20230708174832.0af1d974cf67805dfc8ad655@linux-foundation.org> (raw)
In-Reply-To: <20230707191721.1.Id08823b2f848237ae90ce5c5fa7e027e97c33ad3@changeid>
On Fri, 7 Jul 2023 19:17:25 -0600 Raul E Rangel <rrangel@chromium.org> wrote:
> Right now we are proxying the `console=XXX` command line args to the
> param_setup_earlycon. This is done because the following are
> equivalent:
>
> console=uart[8250],mmio,<addr>[,options]
> earlycon=uart[8250],mmio,<addr>[,options]
>
> In addition, when `earlycon=` or just `earlycon` is specified on the
> command line, we look at the SPCR table or the DT to extract the device
> options.
>
> When `console=` is specified on the command line, it's intention is to
> disable the console. Right now since we are proxying the `console=`
> flag to the earlycon handler, we enable the earlycon_acpi_spcr_enable
> variable when an SPCR table is present. This means that we
> inadvertently enable the earlycon.
>
> This change makes it so we only proxy the console= command if it's
> value is not empty. This way we can correctly handle both cases.
>
I hope someone understands this ;)
Please "grep -r earlycon Documentation" and check for suitable places
to update our documentation.
next prev parent reply other threads:[~2023-07-09 0:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-08 1:17 [PATCH] init: Don't proxy console= to earlycon Raul E Rangel
2023-07-09 0:48 ` Andrew Morton [this message]
2023-07-11 18:15 ` Raul Rangel
2023-07-09 23:46 ` Randy Dunlap
2023-07-10 1:15 ` Mario Limonciello
2023-07-10 2:43 ` Randy Dunlap
2023-07-10 15:30 ` Raul Rangel
2023-07-10 15:41 ` Randy Dunlap
2023-07-14 16:38 ` Petr Mladek
2023-07-14 17:21 ` Raul Rangel
2023-07-14 17:24 ` Raul Rangel
2023-07-14 18:35 ` Petr Mladek
2023-07-14 21:42 ` Raul Rangel
2023-07-18 9:50 ` Petr Mladek
2023-07-28 17:57 ` Raul Rangel
2024-08-08 17:30 ` Raul Rangel
2024-08-21 14:38 ` Petr Mladek
2024-08-21 15:30 ` Raul Rangel
2024-08-22 8:15 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230708174832.0af1d974cf67805dfc8ad655@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Jason@zx2c4.com \
--cc=Liam.Howlett@Oracle.com \
--cc=ardb@kernel.org \
--cc=glider@google.com \
--cc=kramasub@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhe.67@bytedance.com \
--cc=mario.limonciello@amd.com \
--cc=mark.rutland@arm.com \
--cc=rrangel@chromium.org \
--cc=will@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=zhoujie@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox