From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
linux-staging@lists.linux.dev, skhan@linuxfoundation.org,
ivan.orlov0322@gmail.com
Subject: Re: [PATCH] Add struct ad9832_platform_data to the include/linux/iio
Date: Sat, 8 Jul 2023 13:10:29 +0200 [thread overview]
Message-ID: <2023070858-brewing-outpour-764c@gregkh> (raw)
In-Reply-To: <20230707211553.GA110890@madhu-kernel>
On Fri, Jul 07, 2023 at 04:15:53PM -0500, Madhumitha Prabakaran wrote:
> Add struct ad9832_platform_data to the include/linux/iio
> for maintaining code organization and clarity.
>
> Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
> ---
> drivers/staging/iio/frequency/ad9832.c | 3 +--
> drivers/staging/iio/frequency/ad9832.h | 34 --------------------------
> include/linux/iio/frequency/ad9832.h | 30 +++++++++++++++++++++++
No, not yet, sorry. Staging drivers should be self-contained, why does
this .c file need a .h file at all anyway? It should all just be in the
.c file, can you do that instead?
thanks,
greg k-h
next prev parent reply other threads:[~2023-07-08 11:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 21:15 [PATCH] Add struct ad9832_platform_data to the include/linux/iio Madhumitha Prabakaran
2023-07-08 11:10 ` Greg Kroah-Hartman [this message]
2023-07-08 14:45 ` Jonathan Cameron
2023-07-09 23:40 ` Madhumitha Prabakaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023070858-brewing-outpour-764c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Michael.Hennerich@analog.com \
--cc=ivan.orlov0322@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=madhumithabiw@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox