public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: Zhangjin Wu <falcon@tinylab.org>
Cc: arnd@arndb.de, linux-kernel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, thomas@t-8ch.de
Subject: Re: [PATCH v1 3/5] selftests/nolibc: report: align passed, skipped and failed
Date: Sun, 9 Jul 2023 10:51:53 +0200	[thread overview]
Message-ID: <20230709085153.GA9321@1wt.eu> (raw)
In-Reply-To: <9620a07294e4c099587170e84aba167bf849e841.1688633188.git.falcon@tinylab.org>

On Thu, Jul 06, 2023 at 05:10:08PM +0800, Zhangjin Wu wrote:
> align the test values for different runs and different architectures.
> 
> Since the total number of tests is not bigger than 1000 currently, let's
> align them with "%03d".

%03d is not great for those who want to use them in scripts because it will
prepend zeroes. Better use %3d. Look for example:

  $ x=$(printf "%03d\n" 19)
  $ echo $x
  019
  $ echo $((x+1))
  -bash: 019: value too great for base (error token is "019")

Instead:

  $ printf "%3d\n" 19
   19
  $ x=$(printf "%3d\n" 19)
  $ echo $x
  19
  $ echo $((x+1))
  20

If you're fine with it I'll change your patch and commit message
accordingly.

Willy

  reply	other threads:[~2023-07-09  8:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-06  9:02 [PATCH v1 0/5] selftests/nolibc: report: print test status Zhangjin Wu
2023-07-06  9:03 ` [PATCH v1 1/5] selftests/nolibc: report: print a summarized " Zhangjin Wu
2023-07-06  9:08 ` [PATCH v1 2/5] selftests/nolibc: report: print total tests Zhangjin Wu
2023-07-06  9:10 ` [PATCH v1 3/5] selftests/nolibc: report: align passed, skipped and failed Zhangjin Wu
2023-07-09  8:51   ` Willy Tarreau [this message]
2023-07-09 18:51     ` Zhangjin Wu
2023-07-06  9:11 ` [PATCH v1 4/5] selftests/nolibc: report: extrude the test status line Zhangjin Wu
2023-07-09  8:54   ` Willy Tarreau
2023-07-09 19:26     ` Zhangjin Wu
2023-07-10  6:30       ` Willy Tarreau
2023-07-06  9:12 ` [PATCH v1 5/5] selftests/nolibc: report: add newline before test failures Zhangjin Wu
2023-07-09  8:58 ` [PATCH v1 0/5] selftests/nolibc: report: print test status Willy Tarreau
2023-07-09 19:44   ` Zhangjin Wu
2023-07-10  6:32     ` Willy Tarreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230709085153.GA9321@1wt.eu \
    --to=w@1wt.eu \
    --cc=arnd@arndb.de \
    --cc=falcon@tinylab.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=thomas@t-8ch.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox