From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F1F3C0015E for ; Sun, 9 Jul 2023 08:58:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229751AbjGII6l (ORCPT ); Sun, 9 Jul 2023 04:58:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229516AbjGII6k (ORCPT ); Sun, 9 Jul 2023 04:58:40 -0400 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 56727198; Sun, 9 Jul 2023 01:58:38 -0700 (PDT) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 3698wTZc009413; Sun, 9 Jul 2023 10:58:29 +0200 Date: Sun, 9 Jul 2023 10:58:29 +0200 From: Willy Tarreau To: Zhangjin Wu Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, thomas@t-8ch.de Subject: Re: [PATCH v1 0/5] selftests/nolibc: report: print test status Message-ID: <20230709085829.GC9321@1wt.eu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Zhangjin, On Thu, Jul 06, 2023 at 05:02:26PM +0800, Zhangjin Wu wrote: > Hi, Willy > > As you suggested, the 'status: [success|warning|failure]' info is added > to the summary line, with additional newlines around this line to > extrude the status info. at the same time, the total tests is printed, > the passed, skipped and failed values are aligned with '%03d'. So as I mentioned with some commits, I *do* find it important to preserve the convenience of grepping for a single word to from 20 test reports at once and visually check all statuses (and in this sense I like your preference for aligning the words to make them more readable). But having to guess some grep context and see the output garbled clearly does the opposite of what we were looking for in my opinion. Also, I think there's no need for having 5 separate patches to add/remove a line feed. Better discuss an output format that matches everyone's needs and change it at once, this will make the patch more reviewable than having individual changes like this. thanks, willy