From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43BADC0015E for ; Sun, 9 Jul 2023 09:16:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230025AbjGIJQ2 (ORCPT ); Sun, 9 Jul 2023 05:16:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229494AbjGIJQ0 (ORCPT ); Sun, 9 Jul 2023 05:16:26 -0400 Received: from 1wt.eu (ded1.1wt.eu [163.172.96.212]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 698E2B8; Sun, 9 Jul 2023 02:16:25 -0700 (PDT) Received: (from willy@localhost) by pcw.home.local (8.15.2/8.15.2/Submit) id 3699Flap018530; Sun, 9 Jul 2023 11:15:47 +0200 Date: Sun, 9 Jul 2023 11:15:47 +0200 From: Willy Tarreau To: Zhangjin Wu Cc: arnd@arndb.de, david.laight@aculab.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-riscv@lists.infradead.org, thomas@t-8ch.de Subject: Re: [PATCH v6 13/15] selftests/nolibc: add mmap_bad test case Message-ID: <20230709091547.GD9321@1wt.eu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 07, 2023 at 11:05:49PM +0800, Zhangjin Wu wrote: > The length argument of mmap() must be greater than 0, passing a zero > length argument expects failure with -EINVAL. This one doesn't work for me on x86_64 kernel 5.15.112, qemu userland: 46 mmap_bad = <0x0> EEXIST != (<0xffffffffffffffff> EINVAL) [FAIL] This EEXIST actually is the errno from the previous test. If I run the test natively it's OK: $ ./nolibc-test syscall:46 Running test 'syscall' 46 mmap_bad = <0xffffffffffffffff> EINVAL [OK] Errors during this test: 0 I'll queue it anyway for now but it would be nice that we figure what's happening (even if we need to adjust or drop the test if it's a false positive) so that we don't get used to "ah this is a normal error". Willy