public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Kees Cook <keescook@chromium.org>
Subject: drivers/char/ipmi/ipmi_msghandler.c:5194:13: warning: stack frame size (1032) exceeds limit (1024) in 'ipmi_panic_request_and_wait'
Date: Sun, 9 Jul 2023 14:55:06 +0800	[thread overview]
Message-ID: <202307091420.gmc0Q2F3-lkp@intel.com> (raw)

Hi Mark,

FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   1c7873e3364570ec89343ff4877e0f27a7b21a61
commit: c9268ac615f9f6dded7801df5993374598934377 locking/atomic: scripts: add trivial raw_atomic*_<op>()
date:   5 weeks ago
config: arm-randconfig-r006-20230709 (https://download.01.org/0day-ci/archive/20230709/202307091420.gmc0Q2F3-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce: (https://download.01.org/0day-ci/archive/20230709/202307091420.gmc0Q2F3-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307091420.gmc0Q2F3-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/char/ipmi/ipmi_msghandler.c:5194:13: warning: stack frame size (1032) exceeds limit (1024) in 'ipmi_panic_request_and_wait' [-Wframe-larger-than]
    5194 | static void ipmi_panic_request_and_wait(struct ipmi_smi *intf,
         |             ^
   1 warning generated.


vim +/ipmi_panic_request_and_wait +5194 drivers/char/ipmi/ipmi_msghandler.c

895dcfd1cab84d Corey Minyard  2012-03-28  5190  
895dcfd1cab84d Corey Minyard  2012-03-28  5191  /*
895dcfd1cab84d Corey Minyard  2012-03-28  5192   * Inside a panic, send a message and wait for a response.
895dcfd1cab84d Corey Minyard  2012-03-28  5193   */
a567b6230066e3 Corey Minyard  2018-04-05 @5194  static void ipmi_panic_request_and_wait(struct ipmi_smi *intf,
895dcfd1cab84d Corey Minyard  2012-03-28  5195  					struct ipmi_addr *addr,
895dcfd1cab84d Corey Minyard  2012-03-28  5196  					struct kernel_ipmi_msg *msg)
895dcfd1cab84d Corey Minyard  2012-03-28  5197  {
895dcfd1cab84d Corey Minyard  2012-03-28  5198  	struct ipmi_smi_msg  smi_msg;
895dcfd1cab84d Corey Minyard  2012-03-28  5199  	struct ipmi_recv_msg recv_msg;
895dcfd1cab84d Corey Minyard  2012-03-28  5200  	int rv;
895dcfd1cab84d Corey Minyard  2012-03-28  5201  
895dcfd1cab84d Corey Minyard  2012-03-28  5202  	smi_msg.done = dummy_smi_done_handler;
895dcfd1cab84d Corey Minyard  2012-03-28  5203  	recv_msg.done = dummy_recv_done_handler;
895dcfd1cab84d Corey Minyard  2012-03-28  5204  	atomic_add(2, &panic_done_count);
895dcfd1cab84d Corey Minyard  2012-03-28  5205  	rv = i_ipmi_request(NULL,
895dcfd1cab84d Corey Minyard  2012-03-28  5206  			    intf,
895dcfd1cab84d Corey Minyard  2012-03-28  5207  			    addr,
895dcfd1cab84d Corey Minyard  2012-03-28  5208  			    0,
895dcfd1cab84d Corey Minyard  2012-03-28  5209  			    msg,
895dcfd1cab84d Corey Minyard  2012-03-28  5210  			    intf,
895dcfd1cab84d Corey Minyard  2012-03-28  5211  			    &smi_msg,
895dcfd1cab84d Corey Minyard  2012-03-28  5212  			    &recv_msg,
895dcfd1cab84d Corey Minyard  2012-03-28  5213  			    0,
5fdb1fb2abe647 Corey Minyard  2017-09-05  5214  			    intf->addrinfo[0].address,
5fdb1fb2abe647 Corey Minyard  2017-09-05  5215  			    intf->addrinfo[0].lun,
895dcfd1cab84d Corey Minyard  2012-03-28  5216  			    0, 1); /* Don't retry, and don't wait. */
895dcfd1cab84d Corey Minyard  2012-03-28  5217  	if (rv)
895dcfd1cab84d Corey Minyard  2012-03-28  5218  		atomic_sub(2, &panic_done_count);
82802f968bd311 Hidehiro Kawai 2015-07-27  5219  	else if (intf->handlers->flush_messages)
82802f968bd311 Hidehiro Kawai 2015-07-27  5220  		intf->handlers->flush_messages(intf->send_info);
82802f968bd311 Hidehiro Kawai 2015-07-27  5221  
895dcfd1cab84d Corey Minyard  2012-03-28  5222  	while (atomic_read(&panic_done_count) != 0)
895dcfd1cab84d Corey Minyard  2012-03-28  5223  		ipmi_poll(intf);
^1da177e4c3f41 Linus Torvalds 2005-04-16  5224  }
^1da177e4c3f41 Linus Torvalds 2005-04-16  5225  

:::::: The code at line 5194 was first introduced by commit
:::::: a567b6230066e3a2c964e2dc914e7f9a436806c4 ipmi: Change ipmi_smi_t to struct ipmi_smi *

:::::: TO: Corey Minyard <cminyard@mvista.com>
:::::: CC: Corey Minyard <cminyard@mvista.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2023-07-09  6:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202307091420.gmc0Q2F3-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=mark.rutland@arm.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox