From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Zhang Shurong <zhang_shurong@foxmail.com>,
linux-staging@lists.linux.dev, kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Dan Carpenter <error27@gmail.com>, Xu Panda <xu.panda@zte.com.cn>
Subject: Re: [PATCH] staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext()
Date: Sun, 9 Jul 2023 21:42:47 +0200 [thread overview]
Message-ID: <2023070919-monetary-sleet-2f5c@gregkh> (raw)
In-Reply-To: <2a41ca22-a0eb-df38-be43-7175e1230bd0@web.de>
On Sun, Jul 09, 2023 at 09:21:45PM +0200, Markus Elfring wrote:
> > The "exc->key_len" is a u16 that comes from the user. If it's over
> > IW_ENCODING_TOKEN_MAX (64) that could lead to memory corruption.
>
> Please choose an imperative change suggestion.
Please stop reviewing staging patches, it is not helpful for anyone.
greg k-h
next prev parent reply other threads:[~2023-07-09 19:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-09 5:50 [PATCH] staging: ks7010: potential buffer overflow in ks_wlan_set_encode_ext() Zhang Shurong
[not found] ` <2a41ca22-a0eb-df38-be43-7175e1230bd0@web.de>
2023-07-09 19:42 ` Greg Kroah-Hartman [this message]
[not found] ` <e24f9c2c-1163-631a-f8c0-b6dcb445a858@web.de>
2023-07-10 5:41 ` Zhang Shurong
2023-07-10 5:47 ` Greg Kroah-Hartman
2023-07-10 6:08 ` [PATCH] " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023070919-monetary-sleet-2f5c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Markus.Elfring@web.de \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=xu.panda@zte.com.cn \
--cc=zhang_shurong@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox