From: Christoph Hellwig <hch@lst.de>
To: Azat Khuzhin <a3at.mail@gmail.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] Fix writing maj:min to /sys/power/resume (fixes hiberation with systemd)
Date: Tue, 11 Jul 2023 14:08:06 +0200 [thread overview]
Message-ID: <20230711120806.GA27809@lst.de> (raw)
In-Reply-To: <20230711114821.1273-1-a3at.mail@gmail.com>
On Tue, Jul 11, 2023 at 01:48:12PM +0200, Azat Khuzhin wrote:
> resume_store() first calls lookup_bdev() and after tries to handle
> maj:min, but it does not reset the error before, hence if you will write
> maj:min you will get ENOENT:
>
> # echo 259:2 >| /sys/power/resume
> bash: echo: write error: No such file or directory
>
> This also should fix hiberation via systemd, since it uses this way.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2023-07-11 12:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 11:48 [PATCH] Fix writing maj:min to /sys/power/resume (fixes hiberation with systemd) Azat Khuzhin
2023-07-11 12:08 ` Christoph Hellwig [this message]
2023-07-11 18:01 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711120806.GA27809@lst.de \
--to=hch@lst.de \
--cc=a3at.mail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox