From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23087C001DC for ; Tue, 11 Jul 2023 14:25:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233653AbjGKOZA (ORCPT ); Tue, 11 Jul 2023 10:25:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233760AbjGKOYk (ORCPT ); Tue, 11 Jul 2023 10:24:40 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01B4DBC; Tue, 11 Jul 2023 07:24:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CDAE761426; Tue, 11 Jul 2023 14:23:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CD0FEC433C8; Tue, 11 Jul 2023 14:23:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1689085408; bh=y0D8bkf1or402NLl3uVF2AePZpVnhF+paDS0zFSxMIo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YwQyjOn/X9YN5dTU+kbB6ABx98v8Rjj48CHgtatJH113b7zuj1wvMKEBDKjFNrySM Pab87/nXRfGv1JQpuZthb4j3ReqwlayaWWpRGw0pusvpEy7FSJl5fhMUTpydIeJwCg LaJ3HUkPJ58G5UIcvLfo9lBgN+JUGpRB3xlMEEUw= Date: Tue, 11 Jul 2023 16:23:25 +0200 From: Greg Kroah-Hartman To: Dan Carpenter Cc: Thorsten Leemhuis , Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn , linux-kernel@vger.kernel.org, Arnd Bergmann , Kees Cook , Sasha Levin , Tom Gall , kernel-janitors@vger.kernel.org Subject: Re: [PATCH v4] checkpatch: check for missing Fixes tags Message-ID: <2023071117-partition-escargot-9667@gregkh> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 11, 2023 at 04:48:14PM +0300, Dan Carpenter wrote: > This check looks for common words that probably indicate a patch > is a fix. For now the regex is: > > (?:(?:BUG: K.|UB)SAN: |Call Trace:|stable\@|syzkaller)/) > > Why are stable patches encouraged to have a fixes tag? Some people mark > their stable patches as "# 5.10" etc. This is useful but a Fixes tag is > still a good idea. For example, the Fixes tag helps in review. It > helps people to not cherry-pick buggy patches without also > cherry-picking the fix. > > Also if a bug affects the 5.7 kernel some people will round it up to > 5.10+ because 5.7 is not supported on kernel.org. It's possible the Bad > Binder bug was caused by this sort of gap where companies outside of > kernel.org are supporting different kernels from kernel.org. > > Should it be counted as a Fix when a patch just silences harmless > WARN_ON() stack trace. Yes. Definitely. > > Is silencing compiler warnings a fix? It seems unfair to the original > authors, but we use -Werror now, and warnings break the build so let's > just add Fixes tags. I tell people that silencing static checker > warnings is not a fix but the rules on this vary by subsystem. > > Is fixing a minor LTP issue (Linux Test Project) a fix? Probably? It's > hard to know what to do if the LTP test has technically always been > broken. > > One clear false positive from this check is when someone updated their > debug output and included before and after Call Traces. Or when crashes > are introduced deliberately for testing. In those cases, you should > just ignore checkpatch. > > Signed-off-by: Dan Carpenter Acked-by: Greg Kroah-Hartman