Re: [PATCH 1/4] KVM: selftests: Rename the ASSERT_EQ macro

Philippe Mathieu-Daudé
2023-07-18T12:27:08Z

On 12/7/23 09:59, Thomas Huth wrote:
> There is already an ASSERT_EQ macro in the file
> tools/testing/selftests/kselftest_harness.h, so we currently
> can't include test_util.h from the KVM selftests together with
> that file. Rename the macro in the KVM selftests to TEST_ASSERT_EQ
> to avoid the problem - it is also more similar to the other macros
> in test_util.h that way.
>
> Suggested-by: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> .../selftests/kvm/aarch64/aarch32_id_regs.c | 8 +--
> .../selftests/kvm/aarch64/page_fault_test.c | 10 +--
> .../testing/selftests/kvm/include/test_util.h | 4 +-
> tools/testing/selftests/kvm/lib/kvm_util.c | 2 +-
> .../selftests/kvm/max_guest_memory_test.c | 2 +-
> tools/testing/selftests/kvm/s390x/cmma_test.c | 62 +++++++++----------
> tools/testing/selftests/kvm/s390x/memop.c | 6 +-
> tools/testing/selftests/kvm/s390x/tprot.c | 4 +-
> .../x86_64/dirty_log_page_splitting_test.c | 18 +++---
> .../x86_64/exit_on_emulation_failure_test.c | 2 +-
> .../kvm/x86_64/nested_exceptions_test.c | 12 ++--
> .../kvm/x86_64/recalc_apic_map_test.c | 6 +-
> .../selftests/kvm/x86_64/tsc_msrs_test.c | 32 +++++-----
> .../vmx_exception_with_invalid_guest_state.c | 2 +-
> .../selftests/kvm/x86_64/vmx_pmu_caps_test.c | 3 +-
> .../selftests/kvm/x86_64/xapic_state_test.c | 8 +--
> .../selftests/kvm/x86_64/xen_vmcall_test.c | 20 +++---
> 17 files changed, 101 insertions(+), 100 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>