From: Andi Shyti <andi.shyti@kernel.org>
To: Minjie Du <duminjie@vivo.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
"open list:I2C SUBSYSTEM HOST DRIVERS"
<linux-i2c@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
opensource.kernel@vivo.com
Subject: Re: [PATCH v2] i2c: busses: fix parameter check in i2c_gpio_fault_injector_init()
Date: Wed, 12 Jul 2023 17:02:19 +0200 [thread overview]
Message-ID: <20230712150219.pla7unac7e7azwti@intel.intel> (raw)
In-Reply-To: <20230712112223.12286-1-duminjie@vivo.com>
Hi Minje,
On Wed, Jul 12, 2023 at 07:22:22PM +0800, Minjie Du wrote:
> Make IS_ERR() judge the debugfs_create_dir() function return.
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
>
> v1-v2:
> Fix judge typo.
Please next time add the changelog after the "---" section.
You will also need:
Fixes: 14911c6f48ec ("i2c: gpio: add fault injector")
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: <stable@vger.kernel.org> # v4.16+
Said that:
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Andi
> ---
> drivers/i2c/busses/i2c-gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c
> index e5a5b9e8b..545927b96 100644
> --- a/drivers/i2c/busses/i2c-gpio.c
> +++ b/drivers/i2c/busses/i2c-gpio.c
> @@ -265,7 +265,7 @@ static void i2c_gpio_fault_injector_init(struct platform_device *pdev)
> */
> if (!i2c_gpio_debug_dir) {
> i2c_gpio_debug_dir = debugfs_create_dir("i2c-fault-injector", NULL);
> - if (!i2c_gpio_debug_dir)
> + if (IS_ERR(i2c_gpio_debug_dir))
> return;
> }
>
> --
> 2.39.0
>
next prev parent reply other threads:[~2023-07-12 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 11:22 [PATCH v2] i2c: busses: fix parameter check in i2c_gpio_fault_injector_init() Minjie Du
2023-07-12 15:02 ` Andi Shyti [this message]
[not found] ` <1e809b1e-16ec-3e2c-1ced-f50a78811131@web.de>
2023-07-12 21:53 ` [v2] " Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230712150219.pla7unac7e7azwti@intel.intel \
--to=andi.shyti@kernel.org \
--cc=duminjie@vivo.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox