From: Greg KH <gregkh@linuxfoundation.org>
To: Thorsten Leemhuis <linux@leemhuis.info>
Cc: stable@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, Sasha Levin <sashal@kernel.org>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [RFC PATCH v1 0/3] docs: stable-kernel-rules: add delayed backporting option and a few tweaks
Date: Wed, 12 Jul 2023 17:16:49 +0200 [thread overview]
Message-ID: <2023071221-blade-reactive-0707@gregkh> (raw)
In-Reply-To: <a97a37bf-86b5-cd8e-a8ce-00e38720cee4@leemhuis.info>
On Wed, Jul 12, 2023 at 11:30:30AM +0200, Thorsten Leemhuis wrote:
> On 10.07.23 21:51, Greg KH wrote:
> > On Mon, Jul 10, 2023 at 07:10:10PM +0200, Thorsten Leemhuis wrote:
> >> This is a RFC and a bit rough for now. I only set down to create the
> >> first of the three patches. But while doing so I noticed a few things
> >> that seemed odd for me with my background on writing and editing texts.
> >> So I just quickly performed a few additional changes to fix those to see
> >> if the stable team would appreciate them, as this document is clearly
> >> their domain.
> >>
> >> If those changes or even the initial patch are not welcomed, I'll simply
> >> drop them. I'd totally understand this, as texts like these are delicate
> >> and it's easy to accidentlly change the intent or the meaning while
> >> adjusting things in good faith.
> >>
> >> At the same time I might be willing to do a few more changes, if people
> >> like the direction this takes and want a bit more fine tuning.
> >
> > I do like it, many thanks for taking the time to do this work, it's much
> > appreciated.
> >
> > If you resend the first 2 as a non-RFC patch,
>
> BTW: thx again for your uplifting feedback! And in case anyone missed
> it, I send those two patches out yesterday here:
> https://lore.kernel.org/all/cover.1689056247.git.linux@leemhuis.info/
>
> > the last one needs some more work as mentioned.
>
> I have that one in a separate branch now and spitted into four patches;
> the first three basically move text around, which results in a much
> cleaner diff for the last patch that contains actual content changes.
> While working on the latter I noticed one more thing:
>
> ```
> .. warning::
> The -stable-rc tree is a snapshot in time of the stable-queue
> tree and
> will change frequently, hence will be rebased often. It should
> only be
> used for testing purposes (e.g. to be consumed by CI systems).
> ```
>
> That sounded a bit odd to me, as it will scare people away that want to
> test stable -rc's using git;
They are only there for people who _DO_ want to test stable -rc's using
git.
> and I think it doesn't match current practices.
No, it's pretty correct, what does not match? It gets rebased all the
time.
> I'll thus likely
> change the text to something like this,
> unless I'm missing something or someone has a better idea:
> ```
> .. warning::
> The branches in the -stable-rc tree are rebased each time a new -rc
> is released, as they are created by taking the latest release and
> applying the patches from the stable-queue on top.
Yes, that is true, but they are also rebased sometimes in intermediate
places, before a -rc is released, just to give CI systems a chance to
test easier.
These are ONLY for CI systems to use, nothing else should be touching
them. So I think the current text is correct, what am I missing?
thanks,
greg k-h
next prev parent reply other threads:[~2023-07-12 15:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 17:10 [RFC PATCH v1 0/3] docs: stable-kernel-rules: add delayed backporting option and a few tweaks Thorsten Leemhuis
2023-07-10 17:10 ` [RFC PATCH v1 1/3] docs: stable-kernel-rules: mention other usages for stable tag comments Thorsten Leemhuis
2023-07-10 19:43 ` Greg KH
2023-07-11 6:07 ` Thorsten Leemhuis
2023-07-11 10:15 ` Jani Nikula
2023-07-11 10:33 ` Thorsten Leemhuis
2023-07-10 17:10 ` [RFC PATCH v1 2/3] docs: stable-kernel-rules: make rule section more straight forward Thorsten Leemhuis
2023-07-10 19:44 ` Greg KH
2023-07-10 17:10 ` [RFC PATCH v1 3/3] docs: stable-kernel-rules: improve structure to optimize reading flow Thorsten Leemhuis
2023-07-10 19:46 ` Greg KH
2023-07-10 17:18 ` [RFC PATCH v1 0/3] docs: stable-kernel-rules: add delayed backporting option and a few tweaks Thorsten Leemhuis
2023-07-10 19:50 ` Greg KH
2023-07-11 5:57 ` Thorsten Leemhuis
2023-07-11 8:42 ` Johan Hovold
2023-07-11 8:57 ` Thorsten Leemhuis
2023-07-10 19:51 ` Greg KH
2023-07-12 9:30 ` Thorsten Leemhuis
2023-07-12 15:16 ` Greg KH [this message]
2023-07-12 17:02 ` Thorsten Leemhuis
2023-07-12 19:00 ` Greg KH
2023-07-13 8:48 ` Thorsten Leemhuis
2023-07-13 15:06 ` Greg KH
2023-07-13 15:39 ` Conor Dooley
2023-07-13 16:27 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023071221-blade-reactive-0707@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@leemhuis.info \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox