Re: [PATCH 12/20] bcache: move closures to lib/

Randy Dunlap
2023-07-13T03:21:15Z

Hi,

LGTM.
I have a couple of small nits below...

On 7/12/23 14:11, Kent Overstreet wrote:
> From: Kent Overstreet <kent.overstreet@gmail.com>
>
> Prep work for bcachefs - being a fork of bcache it also uses closures
>
> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
> Acked-by: Coly Li <colyli@suse.de>
> ---
> drivers/md/bcache/Kconfig | 10 +-----
> drivers/md/bcache/Makefile | 4 +--
> drivers/md/bcache/bcache.h | 2 +-
> drivers/md/bcache/super.c | 1 -
> drivers/md/bcache/util.h | 3 +-
> .../md/bcache => include/linux}/closure.h | 17 +++++----
> lib/Kconfig | 3 ++
> lib/Kconfig.debug | 9 +++++
> lib/Makefile | 2 ++
> {drivers/md/bcache => lib}/closure.c | 35 +++++++++----------
> 10 files changed, 43 insertions(+), 43 deletions(-)
> rename {drivers/md/bcache => include/linux}/closure.h (97%)
> rename {drivers/md/bcache => lib}/closure.c (88%)
>

> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index ce51d4dc68..3ee25d5dae 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1637,6 +1637,15 @@ config DEBUG_NOTIFIERS
> This is a relatively cheap check but if you care about maximum
> performance, say N.
>
> +config DEBUG_CLOSURES
> + bool "Debug closures (bcache async widgits)"

widgets

> + depends on CLOSURES
> + select DEBUG_FS
> + help
> + Keeps all active closures in a linked list and provides a debugfs
> + interface to list them, which makes it possible to see asynchronous
> + operations that get stuck.

Indent those 3 help text lines with 2 additional spaces, please,
as documented and as is done in (most of) the rest of this file.

With those fixed:

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

thanks.
--
~Randy