Re: [PATCH 04/20] block: Add some exports for bcachefs

Christoph Hellwig
2023-07-24T17:31:09Z

On Wed, Jul 12, 2023 at 05:10:59PM -0400, Kent Overstreet wrote:
> From: Kent Overstreet <kent.overstreet@gmail.com>
>
> - bio_set_pages_dirty(), bio_check_pages_dirty() - dio path

Why? We've so far have been able to get away without file systems
reinventing their own DIO path. I'd really like to keep it that way,
so if you think the iomap dio code should be improved please explain
why. And please also cycle the fsdevel list in.

> - blk_status_to_str() - error messages
> - bio_add_folio() - this should definitely be exported for everyone,
> it's the modern version of bio_add_page()

These look ok to me to go in when the actual user shows up.