Re: [PATCH 06/20] block: Bring back zero_fill_bio_iter

Christoph Hellwig
2023-07-24T17:35:54Z

On Wed, Jul 12, 2023 at 05:11:01PM -0400, Kent Overstreet wrote:
> From: Kent Overstreet <kent.overstreet@gmail.com>
>
> This reverts 6f822e1b5d9dda3d20e87365de138046e3baa03a - this helper is
> used by bcachefs.
>
> Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: linux-block@vger.kernel.org
> ---
> block/bio.c | 6 +++---
> include/linux/bio.h | 7 ++++++-
> 2 files changed, 9 insertions(+), 4 deletions(-)

I really don't see any point in offering this in the block layer. By
the lack of any other caller it obviously isn't such a generic and
always used helper, but more importantly it literally is three lines
of code to implement it.