From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: "Jakub Vaněk" <linuxtardis@gmail.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Mauro Ribeiro <mauro.ribeiro@hardkernel.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH] usb: dwc3: Disable AutoRetry controller feature for dwc_usb3 v2.00a
Date: Wed, 12 Jul 2023 23:02:08 +0000 [thread overview]
Message-ID: <20230712230204.j7g63skeitpdvsom@synopsys.com> (raw)
In-Reply-To: <4246badbbe4c106f965cc8758849390effc48c36.camel@gmail.com>
On Thu, Jul 13, 2023, Jakub Vaněk wrote:
> Hi Thinh,
>
> On Tue, 2023-07-11 at 21:48 +0000, Thinh Nguyen wrote:
> > Hi Jakub,
> >
> > On Thu, Jul 06, 2023, Jakub Vaněk wrote:
> > > On Wed, 2023-07-05 at 22:47 +0000, Thinh Nguyen wrote:
> > > > I brought up this inquiry internally. Please wait as I need to
> > > > review
> > > > this further. The handling for this may be different depending on
> > > > the
> > > > team's feedback.
> > > >
> > >
> > > OK; feel free to contact me if I could be of any help.
> > >
> >
> > Sorry for the delay. After discussion, this behavior is the same
> > across
> > different controller versions. The consensus is to disable this
> > feature
> > altoghether. There will not be any noticeable performance impact.
> >
> > Would you mind revise the patch to disable this feature for all?
>
> Not at all, I have sent a new revision of the patch:
> https://urldefense.com/v3/__https://lore.kernel.org/linux-usb/20230712224037.24948-1-linuxtardis@gmail.com/__;!!A4F2R9G_pg!euvmvJVr_AMCpyd59tiav4Co4u8p0TKzsLq0W7yKoyIlN_K7WFv2GP57wXmsddsJoxsEq6_Bhx8yp5gG8vAqebKhkw$
>
> Reverting the commit altogether seemed preferable to me to updating the
> revision-specific patch. However, if the other way would be better, I
> can send an updated revision.
>
Reverting it is fine also. We'll keep the default setting from
CoreConsultant.
Thanks,
Thinh
prev parent reply other threads:[~2023-07-12 23:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 22:36 [PATCH] usb: dwc3: Disable AutoRetry controller feature for dwc_usb3 v2.00a Jakub Vanek
2023-07-05 22:47 ` Thinh Nguyen
2023-07-06 15:35 ` Jakub Vaněk
2023-07-11 21:48 ` Thinh Nguyen
2023-07-12 22:51 ` Jakub Vaněk
2023-07-12 23:02 ` Thinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230712230204.j7g63skeitpdvsom@synopsys.com \
--to=thinh.nguyen@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxtardis@gmail.com \
--cc=mauro.ribeiro@hardkernel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox