From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B10CEB64DA for ; Wed, 12 Jul 2023 15:11:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233451AbjGLPLW (ORCPT ); Wed, 12 Jul 2023 11:11:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233394AbjGLPLS (ORCPT ); Wed, 12 Jul 2023 11:11:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78FD51BF9 for ; Wed, 12 Jul 2023 08:11:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7B570616F9 for ; Wed, 12 Jul 2023 15:11:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 732A2C433C9; Wed, 12 Jul 2023 15:11:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1689174670; bh=14O7n2R2+7nNC4LbsLJJcewFwSSDuHOWK7ERMRXoOZI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fskZKUksnspUBCgemFrZDIWNaDnzIfkZgYFHwYXYknfNl6jXAkpKSaFh7K+jPWXNP 3CyzEHMtfIhJo/ZnBtE9Cfoc8kkiK68ONECk/c1OUb5tGxKzGtLB2K6IOA2nin+4jn 6njFOAyI9H+1QgSHFqX+BB9fBXFoZcOrhtkgH/aI= Date: Wed, 12 Jul 2023 17:11:06 +0200 From: Greg KH To: "Gangurde, Abhijit" Cc: "linux-kernel@vger.kernel.org" , "Gupta, Nipun" , "Agarwal, Nikhil" , "Gupta, Puneet (DCG-ENG)" , "git (AMD-Xilinx)" , "Simek, Michal" , "Jansen Van Vuuren, Pieter" Subject: Re: [PATCH 3/4] cdx: create sysfs resource files Message-ID: <2023071231-drinking-unskilled-3c00@gregkh> References: <20230711121027.936487-1-abhijit.gangurde@amd.com> <20230711121027.936487-4-abhijit.gangurde@amd.com> <2023071148-grievance-gulf-0841@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 12, 2023 at 01:23:28PM +0000, Gangurde, Abhijit wrote: > [AMD Official Use Only - General] > > > > Resource files provides the basic MMIO regions info to the > > > user-space. Also, resources devices can be used to mmap the > > > MMIO regions in the user-space. > > > > > > Co-developed-by: Puneet Gupta > > > Signed-off-by: Puneet Gupta > > > Co-developed-by: Nipun Gupta > > > Signed-off-by: Nipun Gupta > > > Signed-off-by: Abhijit Gangurde > > > Reviewed-by: Pieter Jansen van Vuuren > vuuren@amd.com> > > > Tested-by: Nikhil Agarwal > > > --- > > > Documentation/ABI/testing/sysfs-bus-cdx | 15 +++ > > > drivers/cdx/cdx.c | 139 +++++++++++++++++++++++- > > > include/linux/cdx/cdx_bus.h | 10 ++ > > > 3 files changed, 163 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/ABI/testing/sysfs-bus-cdx > > b/Documentation/ABI/testing/sysfs-bus-cdx > > > index d9e00058471d..6ca47b6442ce 100644 > > > --- a/Documentation/ABI/testing/sysfs-bus-cdx > > > +++ b/Documentation/ABI/testing/sysfs-bus-cdx > > > @@ -76,3 +76,18 @@ Description: > > > For example:: > > > > > > # echo 1 > /sys/bus/cdx/devices/.../remove > > > + > > > +What: /sys/bus/cdx/devices/.../resource > > > +Date: July 2023 > > > +Contact: puneet.gupta@amd.com > > > +Description: > > > + The resource file contains host addresses of CDX device > > > + resources. Each line of the resource file describes a region > > > + with start, end, and flag fields. > > > > If you documented what this file looked like here, it would be obvious > > that this is not an acceptable sysfs file in any sense of the word. > > > > Please do so, and then fix the patch to not do that at all. > > Similar interface exist for pci and we intended to keep it same way. Could you please elaborate on this. > > # cat /sys/bus/pci/devices/0000\:01\:00.0/resource > 0x0000000092100000 0x00000000921fffff 0x000000000014220c > 0x0000000000000000 0x0000000000000000 0x0000000000000000 Please don't propagate incorrect decisions in the past. Why do you need all of these "resources" in userspace? What tool is going to read and parse them and do something with them? This really violates the "one value per file" sysfs rule, you are going to have to have a huge reason why this is not applicable here, AND you are going to have to document it very very well and get everyone to agree with it. thanks, greg k-h