From: Lee Jones <lee@kernel.org>
To: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Cc: pavel@ucw.cz, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v10 2/5] leds: provide devm_of_led_get_optional()
Date: Thu, 13 Jul 2023 11:02:41 +0100 [thread overview]
Message-ID: <20230713100241.GI10768@google.com> (raw)
In-Reply-To: <20230624084217.3079205-3-jjhiblot@traphandler.com>
On Sat, 24 Jun 2023, Jean-Jacques Hiblot wrote:
> This version of devm_of_led_get() doesn't fail if a LED is not found.
> Instead it returns a NULL pointer.
>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
> drivers/leds/led-class.c | 25 +++++++++++++++++++++++++
> include/linux/leds.h | 2 ++
> 2 files changed, 27 insertions(+)
What Markus said isn't wrong, but isn't a blocker either. He's just
repeating Linus' preferences with respect to commit logs. Ideally you
should be explaining what the problem is and what this patch does to
solve it in a manner that is more directing and less explanatory in the
past tense.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-07-13 10:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-24 8:42 [PATCH v10 0/5] Add a multicolor LED driver for groups of monochromatic LEDs Jean-Jacques Hiblot
2023-06-24 8:42 ` [PATCH v10 1/5] devres: provide devm_krealloc_array() Jean-Jacques Hiblot
2023-06-24 8:42 ` [PATCH v10 2/5] leds: provide devm_of_led_get_optional() Jean-Jacques Hiblot
2023-07-13 10:02 ` Lee Jones [this message]
2023-06-24 8:42 ` [PATCH v10 3/5] leds: class: store the color index in struct led_classdev Jean-Jacques Hiblot
2023-07-13 9:53 ` Lee Jones
2023-07-18 9:04 ` Jean-Jacques Hiblot
2023-06-24 8:42 ` [PATCH v10 4/5] dt-bindings: leds: Add binding for a multicolor group of LEDs Jean-Jacques Hiblot
2023-06-24 8:42 ` [PATCH v10 5/5] leds: Add a multicolor LED driver to group monochromatic LEDs Jean-Jacques Hiblot
2023-07-13 10:06 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230713100241.GI10768@google.com \
--to=lee@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jjhiblot@traphandler.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox