* [PATCH] leds: ip30: Convert to devm_platform_ioremap_resource()
@ 2023-07-04 9:47 Yangtao Li
2023-07-13 10:22 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Yangtao Li @ 2023-07-04 9:47 UTC (permalink / raw)
To: Pavel Machek, Lee Jones; +Cc: Yangtao Li, linux-leds, linux-kernel
Use devm_platform_ioremap_resource() to simplify code.
Signed-off-by: Yangtao Li <frank.li@vivo.com>
---
drivers/leds/leds-ip30.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/leds/leds-ip30.c b/drivers/leds/leds-ip30.c
index 1f952bad0fe8..2df24c303366 100644
--- a/drivers/leds/leds-ip30.c
+++ b/drivers/leds/leds-ip30.c
@@ -27,22 +27,16 @@ static void ip30led_set(struct led_classdev *led_cdev,
static int ip30led_create(struct platform_device *pdev, int num)
{
- struct resource *res;
struct ip30_led *data;
- res = platform_get_resource(pdev, IORESOURCE_MEM, num);
- if (!res)
- return -EBUSY;
-
data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
if (!data)
return -ENOMEM;
- data->reg = devm_ioremap_resource(&pdev->dev, res);
+ data->reg = devm_platform_ioremap_resource(pdev, num);
if (IS_ERR(data->reg))
return PTR_ERR(data->reg);
-
switch (num) {
case IP30_LED_SYSTEM:
data->cdev.name = "white:power";
--
2.39.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] leds: ip30: Convert to devm_platform_ioremap_resource()
2023-07-04 9:47 [PATCH] leds: ip30: Convert to devm_platform_ioremap_resource() Yangtao Li
@ 2023-07-13 10:22 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2023-07-13 10:22 UTC (permalink / raw)
To: Yangtao Li; +Cc: Pavel Machek, linux-leds, linux-kernel
On Tue, 04 Jul 2023, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
> drivers/leds/leds-ip30.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/leds/leds-ip30.c b/drivers/leds/leds-ip30.c
> index 1f952bad0fe8..2df24c303366 100644
> --- a/drivers/leds/leds-ip30.c
> +++ b/drivers/leds/leds-ip30.c
> @@ -27,22 +27,16 @@ static void ip30led_set(struct led_classdev *led_cdev,
>
> static int ip30led_create(struct platform_device *pdev, int num)
> {
> - struct resource *res;
> struct ip30_led *data;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, num);
> - if (!res)
> - return -EBUSY;
> -
> data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
> if (!data)
> return -ENOMEM;
>
> - data->reg = devm_ioremap_resource(&pdev->dev, res);
> + data->reg = devm_platform_ioremap_resource(pdev, num);
> if (IS_ERR(data->reg))
> return PTR_ERR(data->reg);
>
> -
You're not supposed to do that. Separate patch in future please.
But I cannot review what I do not see!
Applied, thanks
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-13 10:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-04 9:47 [PATCH] leds: ip30: Convert to devm_platform_ioremap_resource() Yangtao Li
2023-07-13 10:22 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox