From: Lee Jones <lee@kernel.org>
To: Henning Schild <henning.schild@siemens.com>
Cc: Pavel Machek <pavel@ucw.cz>, Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 2/2] leds: simatic-ipc-leds-gpio: fix comment style in SPDX header
Date: Thu, 13 Jul 2023 16:41:55 +0100 [thread overview]
Message-ID: <20230713154155.GE968624@google.com> (raw)
In-Reply-To: <20230712141013.67140778@md1za8fc.ad001.siemens.net>
On Wed, 12 Jul 2023, Henning Schild wrote:
> Am Wed, 12 Jul 2023 12:52:52 +0100
> schrieb Lee Jones <lee@kernel.org>:
>
> > On Thu, 06 Jul 2023, Henning Schild wrote:
> >
> > > This was found with giving the file to checkpatch.
> > >
> > > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > > ---
> > > drivers/leds/simple/simatic-ipc-leds-gpio.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.h
> > > b/drivers/leds/simple/simatic-ipc-leds-gpio.h index
> > > bf258c32f83d..3d4877aa4e0c 100644 ---
> > > a/drivers/leds/simple/simatic-ipc-leds-gpio.h +++
> > > b/drivers/leds/simple/simatic-ipc-leds-gpio.h @@ -1,4 +1,4 @@
> > > -// SPDX-License-Identifier: GPL-2.0
> > > +/* SPDX-License-Identifier: GPL-2.0 */
> >
> > What prompted this change?
> >
> > % git grep -F "// SPDX-License-Identifier:" -- drivers/leds | wc -l
> > 117
> > % git grep -F "/* SPDX-License-Identifier:" -- drivers/leds | wc -l
> > 2
> >
>
> ./scripts/checkpatch.pl --no-tree --file
> drivers/leds/simple/simatic-ipc-leds-gpio.h
>
> it boils down to header versus c-file, not sure why headers prefer that
> other style
Ah yes, that one. Okay.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-07-13 15:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 16:10 [PATCH 0/2] platform/x86: simatic-ipc: minor cleanups Henning Schild
2023-07-06 16:10 ` [PATCH 1/2] platform/x86: simatic-ipc: drop PCI runtime depends and header Henning Schild
2023-07-14 9:32 ` Hans de Goede
2023-07-06 16:10 ` [PATCH 2/2] leds: simatic-ipc-leds-gpio: fix comment style in SPDX header Henning Schild
2023-07-12 11:52 ` Lee Jones
2023-07-12 12:10 ` Henning Schild
2023-07-13 15:41 ` Lee Jones [this message]
2023-07-13 15:42 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230713154155.GE968624@google.com \
--to=lee@kernel.org \
--cc=hdegoede@redhat.com \
--cc=henning.schild@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox