[PATCH 0/2] platform/x86: simatic-ipc: minor cleanups

[PATCH 0/2] platform/x86: simatic-ipc: minor cleanups

[Henning Schild]

Two rather trivial things i found while working on something else.
Sending that as its own series to decouple that from that other topic.

Henning Schild (2):
  platform/x86: simatic-ipc: drop PCI runtime depends and header
  leds: simatic-ipc-leds-gpio: fix comment style in SPDX header

 drivers/leds/simple/simatic-ipc-leds-gpio.h | 2 +-
 drivers/platform/x86/Kconfig                | 1 -
 drivers/platform/x86/simatic-ipc.c          | 1 -
 3 files changed, 1 insertion(+), 3 deletions(-)

-- 
2.39.3

[PATCH 1/2] platform/x86: simatic-ipc: drop PCI runtime depends and header

[Henning Schild]

We do not use PCI any longer since
commit 446f0cf9e08b ("platform/x86: simatic-ipc: drop custom P2SB bar code")'

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 drivers/platform/x86/Kconfig       | 1 -
 drivers/platform/x86/simatic-ipc.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 49c2c4cd8d00..d9ba3cb9ac50 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -1076,7 +1076,6 @@ config INTEL_SCU_IPC_UTIL
 
 config SIEMENS_SIMATIC_IPC
 	tristate "Siemens Simatic IPC Class driver"
-	depends on PCI
 	help
 	  This Simatic IPC class driver is the central of several drivers. It
 	  is mainly used for system identification, after which drivers in other
diff --git a/drivers/platform/x86/simatic-ipc.c b/drivers/platform/x86/simatic-ipc.c
index c773995b230d..2523f6dc9db9 100644
--- a/drivers/platform/x86/simatic-ipc.c
+++ b/drivers/platform/x86/simatic-ipc.c
@@ -15,7 +15,6 @@
 #include <linux/dmi.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
-#include <linux/pci.h>
 #include <linux/platform_data/x86/simatic-ipc.h>
 #include <linux/platform_device.h>
 
-- 
2.39.3

Re: [PATCH 1/2] platform/x86: simatic-ipc: drop PCI runtime depends and header

[Hans de Goede]

Hi,

On 7/6/23 18:10, Henning Schild wrote:
> We do not use PCI any longer since
> commit 446f0cf9e08b ("platform/x86: simatic-ipc: drop custom P2SB bar code")'
> 
> Signed-off-by: Henning Schild <henning.schild@siemens.com>

Thank you. I've merged this into the new platform-drivers-x86-simatic-ipc
branch where I'm collecting all the pending platform/x86: simatic-ipc
work.

Regards,

Hans


> ---
>  drivers/platform/x86/Kconfig       | 1 -
>  drivers/platform/x86/simatic-ipc.c | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 49c2c4cd8d00..d9ba3cb9ac50 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1076,7 +1076,6 @@ config INTEL_SCU_IPC_UTIL
>  
>  config SIEMENS_SIMATIC_IPC
>  	tristate "Siemens Simatic IPC Class driver"
> -	depends on PCI
>  	help
>  	  This Simatic IPC class driver is the central of several drivers. It
>  	  is mainly used for system identification, after which drivers in other
> diff --git a/drivers/platform/x86/simatic-ipc.c b/drivers/platform/x86/simatic-ipc.c
> index c773995b230d..2523f6dc9db9 100644
> --- a/drivers/platform/x86/simatic-ipc.c
> +++ b/drivers/platform/x86/simatic-ipc.c
> @@ -15,7 +15,6 @@
>  #include <linux/dmi.h>
>  #include <linux/kernel.h>
>  #include <linux/module.h>
> -#include <linux/pci.h>
>  #include <linux/platform_data/x86/simatic-ipc.h>
>  #include <linux/platform_device.h>
>  

[PATCH 2/2] leds: simatic-ipc-leds-gpio: fix comment style in SPDX header

[Henning Schild]

This was found with giving the file to checkpatch.

Signed-off-by: Henning Schild <henning.schild@siemens.com>
---
 drivers/leds/simple/simatic-ipc-leds-gpio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.h b/drivers/leds/simple/simatic-ipc-leds-gpio.h
index bf258c32f83d..3d4877aa4e0c 100644
--- a/drivers/leds/simple/simatic-ipc-leds-gpio.h
+++ b/drivers/leds/simple/simatic-ipc-leds-gpio.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Siemens SIMATIC IPC driver for GPIO based LEDs
  *
-- 
2.39.3

Re: [PATCH 2/2] leds: simatic-ipc-leds-gpio: fix comment style in SPDX header

[Lee Jones]

On Thu, 06 Jul 2023, Henning Schild wrote:

> This was found with giving the file to checkpatch.
> 
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  drivers/leds/simple/simatic-ipc-leds-gpio.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.h b/drivers/leds/simple/simatic-ipc-leds-gpio.h
> index bf258c32f83d..3d4877aa4e0c 100644
> --- a/drivers/leds/simple/simatic-ipc-leds-gpio.h
> +++ b/drivers/leds/simple/simatic-ipc-leds-gpio.h
> @@ -1,4 +1,4 @@
> -// SPDX-License-Identifier: GPL-2.0
> +/* SPDX-License-Identifier: GPL-2.0 */

What prompted this change?

% git grep -F "// SPDX-License-Identifier:" -- drivers/leds | wc -l
117
% git grep -F "/* SPDX-License-Identifier:" -- drivers/leds | wc -l
2

-- 
Lee Jones [李琼斯]

Re: [PATCH 2/2] leds: simatic-ipc-leds-gpio: fix comment style in SPDX header

[Henning Schild]

Am Wed, 12 Jul 2023 12:52:52 +0100
schrieb Lee Jones <lee@kernel.org>:

> On Thu, 06 Jul 2023, Henning Schild wrote:
> 
> > This was found with giving the file to checkpatch.
> > 
> > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > ---
> >  drivers/leds/simple/simatic-ipc-leds-gpio.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.h
> > b/drivers/leds/simple/simatic-ipc-leds-gpio.h index
> > bf258c32f83d..3d4877aa4e0c 100644 ---
> > a/drivers/leds/simple/simatic-ipc-leds-gpio.h +++
> > b/drivers/leds/simple/simatic-ipc-leds-gpio.h @@ -1,4 +1,4 @@
> > -// SPDX-License-Identifier: GPL-2.0
> > +/* SPDX-License-Identifier: GPL-2.0 */  
> 
> What prompted this change?
> 
> % git grep -F "// SPDX-License-Identifier:" -- drivers/leds | wc -l
> 117
> % git grep -F "/* SPDX-License-Identifier:" -- drivers/leds | wc -l
> 2
> 

./scripts/checkpatch.pl --no-tree --file
drivers/leds/simple/simatic-ipc-leds-gpio.h 

it boils down to header versus c-file, not sure why headers prefer that
other style

Henning

Re: [PATCH 2/2] leds: simatic-ipc-leds-gpio: fix comment style in SPDX header

[Lee Jones]

On Wed, 12 Jul 2023, Henning Schild wrote:

> Am Wed, 12 Jul 2023 12:52:52 +0100
> schrieb Lee Jones <lee@kernel.org>:
> 
> > On Thu, 06 Jul 2023, Henning Schild wrote:
> > 
> > > This was found with giving the file to checkpatch.
> > > 
> > > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > > ---
> > >  drivers/leds/simple/simatic-ipc-leds-gpio.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/leds/simple/simatic-ipc-leds-gpio.h
> > > b/drivers/leds/simple/simatic-ipc-leds-gpio.h index
> > > bf258c32f83d..3d4877aa4e0c 100644 ---
> > > a/drivers/leds/simple/simatic-ipc-leds-gpio.h +++
> > > b/drivers/leds/simple/simatic-ipc-leds-gpio.h @@ -1,4 +1,4 @@
> > > -// SPDX-License-Identifier: GPL-2.0
> > > +/* SPDX-License-Identifier: GPL-2.0 */  
> > 
> > What prompted this change?
> > 
> > % git grep -F "// SPDX-License-Identifier:" -- drivers/leds | wc -l
> > 117
> > % git grep -F "/* SPDX-License-Identifier:" -- drivers/leds | wc -l
> > 2
> > 
> 
> ./scripts/checkpatch.pl --no-tree --file
> drivers/leds/simple/simatic-ipc-leds-gpio.h 
> 
> it boils down to header versus c-file, not sure why headers prefer that
> other style

Ah yes, that one.  Okay.

-- 
Lee Jones [李琼斯]

Re: [PATCH 2/2] leds: simatic-ipc-leds-gpio: fix comment style in SPDX header

[Lee Jones]

On Thu, 06 Jul 2023, Henning Schild wrote:

> This was found with giving the file to checkpatch.
> 
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  drivers/leds/simple/simatic-ipc-leds-gpio.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

-- 
Lee Jones [李琼斯]