From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: 王明-软件底层技术部 <machel@vivo.com>
Cc: David Hildenbrand <david@redhat.com>,
Akinobu Mita <akinobu.mita@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
"opensource.kernel" <opensource.kernel@vivo.com>
Subject: Re: 回复: [PATCH v1] lib:Fix an NULL vs IS_ERR() bug for debugfs_create_dir() in err_inject_init()
Date: Thu, 13 Jul 2023 08:01:08 +0200 [thread overview]
Message-ID: <2023071334-tattle-mobile-dab4@gregkh> (raw)
In-Reply-To: <SG2PR06MB37435A03DEC11F265C849093BD37A@SG2PR06MB3743.apcprd06.prod.outlook.com>
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Thu, Jul 13, 2023 at 02:09:03AM +0000, 王明-软件底层技术部 wrote:
> Hi greg k-h
> I proposed this patch because I found that debugfs_create_dir() does
> not return NULL, but returns an error pointer, executing if statements
> according to the original code meaning no error, so I made this change
> : )
That's fine, but you should fix this up to use the api properly if you
are making these types of changes, otherwise we just have to do it again
in the future.
thanks,
greg k-h
prev parent reply other threads:[~2023-07-13 6:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 13:52 [PATCH v1] lib:Fix an NULL vs IS_ERR() bug for debugfs_create_dir() in err_inject_init() Wang Ming
2023-07-12 16:34 ` Greg Kroah-Hartman
[not found] ` <SG2PR06MB37435A03DEC11F265C849093BD37A@SG2PR06MB3743.apcprd06.prod.outlook.com>
2023-07-13 6:01 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023071334-tattle-mobile-dab4@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=machel@vivo.com \
--cc=opensource.kernel@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox