From: Peter Zijlstra <peterz@infradead.org>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
Bruno Goncalves <bgoncalv@redhat.com>,
x86@kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [6.5.0-rc1] unchecked MSR access error: RDMSR from 0xe2 at rIP: 0xffffffff87090227 (native_read_msr+0x7/0x40) (intel_idle_init_cstates_icpu)
Date: Sat, 15 Jul 2023 00:02:20 +0200 [thread overview]
Message-ID: <20230714220220.GC3273303@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <6ce7c4d8-3320-7712-a562-a43224c2602b@linux.intel.com>
On Fri, Jul 14, 2023 at 02:47:24PM -0700, Arjan van de Ven wrote:
> > I still don't know why this needs to be in intel_idle.
>
> we can do a seperate idle driver; it'll still be x86 specific (since
> idle really is arch specific)... and then the umwait parts of this
> will be Intel specific.. as well any future idle methods .. and I'm
> not sure the AMD folks would even want it used .... at which point it
> ends up Intel specific fully and we now have 2 Intel idle drivers. I
> don't see how that makes sense.
intel-idle is huge, the last thing it needs is yet another little driver
hidding inside it.
Creating a new simple and small x86-guest cpuidle driver seems, well,
simpler.
And the whole umwait / mwaitx thing really isn't that hard, this is all
indirect functions anyway. All that thing needs to do is amortize the
VMEXIT cost.
next prev parent reply other threads:[~2023-07-14 22:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 9:11 [6.5.0-rc1] unchecked MSR access error: RDMSR from 0xe2 at rIP: 0xffffffff87090227 (native_read_msr+0x7/0x40) (intel_idle_init_cstates_icpu) Bruno Goncalves
2023-07-11 11:24 ` Peter Zijlstra
2023-07-11 12:25 ` Bruno Goncalves
2023-07-11 12:55 ` Peter Zijlstra
2023-07-11 13:15 ` Peter Zijlstra
2023-07-11 13:25 ` Peter Zijlstra
2023-07-11 18:37 ` Wysocki, Rafael J
2023-07-11 18:39 ` Arjan van de Ven
2023-07-14 21:11 ` Peter Zijlstra
2023-07-14 21:47 ` Arjan van de Ven
2023-07-14 22:02 ` Peter Zijlstra [this message]
2023-07-14 21:10 ` Peter Zijlstra
2023-07-14 21:45 ` Arjan van de Ven
2023-07-14 21:55 ` Peter Zijlstra
2023-07-14 22:28 ` Peter Zijlstra
2023-07-11 14:26 ` Arjan van de Ven
2023-07-11 15:32 ` Peter Zijlstra
2023-07-11 14:22 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230714220220.GC3273303@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=arjan@linux.intel.com \
--cc=bgoncalv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox