From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C6EAEB64DC for ; Sat, 15 Jul 2023 04:07:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230354AbjGOEHa (ORCPT ); Sat, 15 Jul 2023 00:07:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229490AbjGOEH2 (ORCPT ); Sat, 15 Jul 2023 00:07:28 -0400 Received: from out-55.mta1.migadu.com (out-55.mta1.migadu.com [95.215.58.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5D42835A9 for ; Fri, 14 Jul 2023 21:07:24 -0700 (PDT) Date: Sat, 15 Jul 2023 13:07:13 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1689394042; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=U2Q7rt32186jYQFvLUEX++gzKm12n7FO2FEO9lwjWmk=; b=DT9marXLx4M1KVinOFTWRRs5dX/E24SD5s4hwxm+uHKeuIyMfuNOmRK5HwMF1kHveBDm/N ibJyvwV8VZD2jd9WyRIXHobeWUJ4P1YNav1dsyFMLcpveLmDEKUIrzIM7p2WKVdE7bYj1r YDPx0NaI6zxR+0xRytxg5LwS/Z43dEU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Naoya Horiguchi To: Jiaqi Yan Cc: naoya.horiguchi@nec.com, linmiaohe@huawei.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, willy@infradead.org Subject: Re: [PATCH v1] mm/hwpoison: rename hwp_walk* to hwpoison_walk* Message-ID: <20230715040713.GA2352837@u2004> References: <20230713235553.4121855-1-jiaqiyan@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230713235553.4121855-1-jiaqiyan@google.com> X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 13, 2023 at 11:55:53PM +0000, Jiaqi Yan wrote: > In the discussion of "Improve hugetlbfs read on HWPOISON hugepages", > Matthew Wilcox suggests hwp is a bad abbreviation of hwpoison, as hwp > is already used as "an acronym by acpi, intel_pstate, some clock > drivers, an ethernet driver, and a scsi driver"[1]. > > So rename hwp_walk and hwp_walk_ops to hwpoison_walk and > hwpoison_walk_ops respectively. > > raw_hwp_(page|list), *_raw_hwp, and raw_hwp_unreliable flag are other > major appearances of "hwp". However, given the "raw" hint in the name, > it is easy to differentiate them from other "hwp" acronyms. Since > renaming them is not as straightforward as renaming hwp_walk*, they > are not covered by this commit. > > [1] https://lore.kernel.org/lkml/20230707201904.953262-5-jiaqiyan@google.com/T/#me6fecb8ce1ad4d5769199c9e162a44bc88f7bdec > > Signed-off-by: Jiaqi Yan Looks good to me. Thank you. Acked-by: Naoya Horiguchi