Re: [PATCH 1/7] ARM: dts: exynos: k3g: Add WiFi card support

Krzysztof Kozlowski
2023-07-19T09:05:29Z

On 17/07/2023 00:05, Markuss Broks wrote:
> This device has Broadcom BCM4354 WiFi card installed,
> which uses SDIO interface.
>
> Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
> ---

> &pinctrl_0 {
> s2mps11_irq: s2mps11-irq-pins {
> samsung,pins = "gpx0-7";
> @@ -628,6 +652,11 @@ touch_irq: touch-irq-pins {
> samsung,pins = "gpx1-6";
> samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
> };
> +
> + wlan_reset: wlan-reset {

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

This is a requirement since few months (half a year?).

Best regards,
Krzysztof