Re: [PATCH 5/7] ARM: dts: exynos: k3g: Add notification LED support

Krzysztof Kozlowski
2023-07-19T09:17:37Z

On 17/07/2023 00:05, Markuss Broks wrote:
> This device has a Texas Instruments LP5562 LED controller
> which controls the LEDs which are used as notification lights.
> It has three colors which can be combined, supports pulse mode
> and other various features.
>
> Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
> ---
> arch/arm/boot/dts/exynos5422-samsung-k3g.dts | 47 ++++++++++++++++++++
> 1 file changed, 47 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5422-samsung-k3g.dts b/arch/arm/boot/dts/exynos5422-samsung-k3g.dts
> index b3576a745054..813dbf0438de 100644
> --- a/arch/arm/boot/dts/exynos5422-samsung-k3g.dts
> +++ b/arch/arm/boot/dts/exynos5422-samsung-k3g.dts
> @@ -10,6 +10,7 @@
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/input/input.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/leds/common.h>
> #include "exynos5800.dtsi"
> #include "exynos5422-cpus.dtsi"
>
> @@ -131,6 +132,52 @@ touchkey@20 {
> };
> };
>
> + i2c-led {
> + compatible = "i2c-gpio";
> +
> + sda-gpios = <&gpy3 6 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + scl-gpios = <&gpy3 7 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + i2c-gpio,delay-us = <2>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + lp5562@30 {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Most likely this is led-controller

Best regards,
Krzysztof