public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: joeyli <jlee@suse.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Chun-Yi Lee <joeyli.kernel@gmail.com>,
	linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Marcel Holtmann <marcel@holtmann.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] Bluetooth: hci_event: Ignore NULL link key in hci_link_key_notify_evt()
Date: Mon, 17 Jul 2023 13:51:50 +0800	[thread overview]
Message-ID: <20230717055150.GO5866@linux-l9pv.suse> (raw)
In-Reply-To: <8eeb958e-d947-2f6d-5942-d30746cf1268@web.de>

Hi Markus,

Thanks for your review!

On Fri, Jul 14, 2023 at 10:30:17PM +0200, Markus Elfring wrote:
> …
> > We can ignore null link key in the handler of "Link Key Notification
> > event" to relieve the attack. …
> 
> Are imperative change descriptions still preferred?
> 
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc1#n94
> 
> 
> How do you think about to add the tag “Fixes” because of
> an added case distinction?
>

Sorry for I didn't capture your point. The "Link Key Notification event" 
is a term in bluetooth-core spec. What should I change in my patch
description?

Thanks a lot!
Joey Le

  parent reply	other threads:[~2023-07-17  5:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-14 16:12 [PATCH] Bluetooth: hci_event: Ignore NULL link key Lee, Chun-Yi
2023-07-14 18:44 ` Luiz Augusto von Dentz
2023-07-17  5:38   ` joeyli
     [not found] ` <8eeb958e-d947-2f6d-5942-d30746cf1268@web.de>
2023-07-17  5:51   ` joeyli [this message]
     [not found]     ` <7cae670e-b7c5-470b-536b-ab03513cd0a3@web.de>
2023-07-17 10:23       ` [PATCH] Bluetooth: hci_event: Ignore NULL link key in hci_link_key_notify_evt() joeyli
2023-07-17 11:25         ` Dan Carpenter
2023-07-17 15:48           ` joeyli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230717055150.GO5866@linux-l9pv.suse \
    --to=jlee@suse.com \
    --cc=Markus.Elfring@web.de \
    --cc=davem@davemloft.net \
    --cc=joeyli.kernel@gmail.com \
    --cc=johan.hedberg@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox