From: Dmitry Osipenko <dmitry.osipenko@collabora.com>
To: Rob Herring <robh@kernel.org>,
Steven Price <steven.price@arm.com>,
Boris Brezillon <boris.brezillon@collabora.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: [PATCH v1] drm/panfrost: Sync IRQ by job's timeout handler
Date: Mon, 17 Jul 2023 09:52:54 +0300 [thread overview]
Message-ID: <20230717065254.1061033-1-dmitry.osipenko@collabora.com> (raw)
Panfrost IRQ handler may stuck for a long time, for example this happens
when there is a bad HDMI connection and HDMI handler takes a long time to
finish processing, holding Panfrost. Make Panfrost's job timeout handler
to sync IRQ before checking fence signal status in order to prevent
spurious job timeouts due to a slow IRQ processing.
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
drivers/gpu/drm/panfrost/panfrost_job.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c
index dbc597ab46fb..a356163da22d 100644
--- a/drivers/gpu/drm/panfrost/panfrost_job.c
+++ b/drivers/gpu/drm/panfrost/panfrost_job.c
@@ -713,6 +713,8 @@ static enum drm_gpu_sched_stat panfrost_job_timedout(struct drm_sched_job
struct panfrost_device *pfdev = job->pfdev;
int js = panfrost_job_get_slot(job);
+ synchronize_irq(pfdev->js->irq);
+
/*
* If the GPU managed to complete this jobs fence, the timeout is
* spurious. Bail out.
--
2.41.0
next reply other threads:[~2023-07-17 6:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 6:52 Dmitry Osipenko [this message]
2023-07-17 7:05 ` [PATCH v1] drm/panfrost: Sync IRQ by job's timeout handler Boris Brezillon
2023-07-17 7:20 ` Dmitry Osipenko
2023-07-17 7:49 ` Boris Brezillon
2023-07-17 8:06 ` Steven Price
2023-07-17 8:49 ` Boris Brezillon
2023-07-17 8:59 ` Steven Price
2023-07-17 13:30 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230717065254.1061033-1-dmitry.osipenko@collabora.com \
--to=dmitry.osipenko@collabora.com \
--cc=boris.brezillon@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=steven.price@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox