From: Kees Cook <keescook@chromium.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] seq_file: Replace strncpy()+nul by strscpy()
Date: Mon, 17 Jul 2023 15:58:29 -0700 [thread overview]
Message-ID: <202307171558.09183D81@keescook> (raw)
In-Reply-To: <ZLVm2FLCRSnlYVUC@smile.fi.intel.com>
On Mon, Jul 17, 2023 at 07:05:44PM +0300, Andy Shevchenko wrote:
> On Mon, Jul 17, 2023 at 08:43:55AM -0700, Kees Cook wrote:
> > On Mon, Jul 17, 2023 at 12:33:32PM +0300, Andy Shevchenko wrote:
>
> ...
>
> > I think this doesn't need to use seq_show_option_n() at all.
>
> Quite likely. Nevertheless, it's one of the dozens (?) warnings like this.
>
> ...
>
> > Reviewed-by: Kees Cook <keescook@chromium.org>
>
> Thank you for the review!
>
> I think it's you who may take it as seq_file.h seems everybody's playground.
Ah, good point. :P
--
Kees Cook
next prev parent reply other threads:[~2023-07-17 22:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 9:33 [PATCH v1 1/1] seq_file: Replace strncpy()+nul by strscpy() Andy Shevchenko
2023-07-17 15:43 ` Kees Cook
2023-07-17 16:05 ` Andy Shevchenko
2023-07-17 22:58 ` Kees Cook [this message]
2023-07-17 23:09 ` Kees Cook
2023-07-19 5:00 ` Kees Cook
2023-07-19 5:26 ` Andy Shevchenko
2023-07-18 9:42 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202307171558.09183D81@keescook \
--to=keescook@chromium.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox