From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFB8BEB64DC for ; Mon, 17 Jul 2023 22:58:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230144AbjGQW6j (ORCPT ); Mon, 17 Jul 2023 18:58:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50542 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbjGQW6g (ORCPT ); Mon, 17 Jul 2023 18:58:36 -0400 Received: from mail-oo1-xc36.google.com (mail-oo1-xc36.google.com [IPv6:2607:f8b0:4864:20::c36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F97812D for ; Mon, 17 Jul 2023 15:58:32 -0700 (PDT) Received: by mail-oo1-xc36.google.com with SMTP id 006d021491bc7-55e04a83465so3235082eaf.3 for ; Mon, 17 Jul 2023 15:58:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1689634711; x=1692226711; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DXBV/2bjPwiYS8/exEYcrIZKRRy4LswAgUjKyTXo1Qg=; b=BIb1WxzpDndftoSsHfDcuFsuU1AktYDefj1plXXrfhwQnJxz9CG1e85DYQUGj7Hn9a Ns7+VLbARCxMXbMHd/ugfmyWDtilfWM7eZIt3uE2bi7kLlSBdh7DuG532t4i+idiYq+r FAatICz1PyJc1Zy08rlNc0zovdt6m62tvxPGQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689634711; x=1692226711; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DXBV/2bjPwiYS8/exEYcrIZKRRy4LswAgUjKyTXo1Qg=; b=e0kc6+gMlAexcYiNAJU/pUZy+LYApXYIWTZjiVB2dSmow5ZK+ng9EfeC0zXf3k1I9n VZgQkyJS7szP38bA2TWXZ4gr1neHPj0CwkBoIMKNt214yetxVDxJePoPTCUXx7fez0Eu 4RGuMN06/n62nmvs3AmN56gwx4/I8BXJ4Au4rT3SRxtG3x0uzEE05fCtt6aeISlwuQ2d Nl/9H89YM5JHXqsitdSQhRpVmEQ0rURaQF75RGeANEdJd4IWLB43cwMCK7EP53KZiZtV lZgc/ge/5+uW+dTm4Iu/WqE8gtFc1Fu7OpeQXG3Ix2HHSo0BnQtlNS7REiOssXO9lbcW scDg== X-Gm-Message-State: ABy/qLYJ+flzAQlBwhYV9WIh91XAMhu57zAkI6c8DyK+vijzaj5ftgpg m3XE2reOgDnW3cCzQUo9VOvHjQ9x9iZdahlCSgA= X-Google-Smtp-Source: APBJJlHmb/dNiyQOJeC3Ts7HefUDiZyi1y6NEW7+G54thcMrg7Ty39Pdk2XVz2OTyl9esC4YZ7VTNA== X-Received: by 2002:a05:6358:7189:b0:135:725f:a8af with SMTP id t9-20020a056358718900b00135725fa8afmr1128909rwt.15.1689634711307; Mon, 17 Jul 2023 15:58:31 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id x15-20020a056a00270f00b0067f2413bf6dsm291057pfv.106.2023.07.17.15.58.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jul 2023 15:58:30 -0700 (PDT) Date: Mon, 17 Jul 2023 15:58:29 -0700 From: Kees Cook To: Andy Shevchenko Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/1] seq_file: Replace strncpy()+nul by strscpy() Message-ID: <202307171558.09183D81@keescook> References: <20230717093332.54236-1-andriy.shevchenko@linux.intel.com> <202307170826.397635AD@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 17, 2023 at 07:05:44PM +0300, Andy Shevchenko wrote: > On Mon, Jul 17, 2023 at 08:43:55AM -0700, Kees Cook wrote: > > On Mon, Jul 17, 2023 at 12:33:32PM +0300, Andy Shevchenko wrote: > > ... > > > I think this doesn't need to use seq_show_option_n() at all. > > Quite likely. Nevertheless, it's one of the dozens (?) warnings like this. > > ... > > > Reviewed-by: Kees Cook > > Thank you for the review! > > I think it's you who may take it as seq_file.h seems everybody's playground. Ah, good point. :P -- Kees Cook