From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: John Ogness <john.ogness@linutronix.de>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH printk v3 3/7] printk: Keep non-panic-CPUs out of console lock
Date: Tue, 18 Jul 2023 12:17:45 +0900 [thread overview]
Message-ID: <20230718031745.GA955071@google.com> (raw)
In-Reply-To: <20230717194607.145135-4-john.ogness@linutronix.de>
On (23/07/17 21:52), John Ogness wrote:
>
> When in a panic situation, non-panic CPUs should avoid holding the
> console lock so as not to contend with the panic CPU. This is already
> implemented with abandon_console_lock_in_panic(), which is checked
> after each printed line. However, non-panic CPUs should also avoid
> trying to acquire the console lock during a panic.
>
> Modify console_trylock() to fail and console_lock() to block() when
> called from a non-panic CPU during a panic.
>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
next prev parent reply other threads:[~2023-07-18 3:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 19:46 [PATCH printk v3 0/7] various cleanups John Ogness
2023-07-17 19:46 ` [PATCH printk v3 1/7] kdb: Do not assume write() callback available John Ogness
2023-07-17 19:46 ` [PATCH printk v3 2/7] printk: Reduce console_unblank() usage in unsafe scenarios John Ogness
2023-07-18 3:39 ` Sergey Senozhatsky
2023-07-18 10:21 ` Petr Mladek
2023-07-17 19:46 ` [PATCH printk v3 3/7] printk: Keep non-panic-CPUs out of console lock John Ogness
2023-07-18 3:17 ` Sergey Senozhatsky [this message]
2023-07-18 10:23 ` Petr Mladek
2023-07-17 19:46 ` [PATCH printk v3 4/7] printk: Do not take console lock for console_flush_on_panic() John Ogness
2023-07-18 3:18 ` Sergey Senozhatsky
2023-07-18 10:28 ` Petr Mladek
2023-07-17 19:46 ` [PATCH printk v3 5/7] printk: Consolidate console deferred printing John Ogness
2023-07-17 19:46 ` [PATCH printk v3 6/7] printk: Add per-console suspended state John Ogness
2023-07-17 19:46 ` [PATCH printk v3 7/7] printk: Rename abandon_console_lock_in_panic() to other_cpu_in_panic() John Ogness
2023-07-18 10:44 ` [PATCH printk v3 0/7] various cleanups Petr Mladek
2023-07-21 9:17 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718031745.GA955071@google.com \
--to=senozhatsky@chromium.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox