From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 912FFC0015E
	for <linux-kernel@archiver.kernel.org>; Tue, 18 Jul 2023 19:11:37 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230035AbjGRTLf (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Tue, 18 Jul 2023 15:11:35 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49552 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231185AbjGRTLT (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 18 Jul 2023 15:11:19 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70F89F4
        for <linux-kernel@vger.kernel.org>; Tue, 18 Jul 2023 12:11:18 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
         key-exchange X25519 server-signature RSA-PSS (2048 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id 0638661523
        for <linux-kernel@vger.kernel.org>; Tue, 18 Jul 2023 19:11:18 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A735C433C7;
        Tue, 18 Jul 2023 19:11:17 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1689707477;
        bh=+HkpbelCVxn3hOwtOAxEdmpD4XslKX+FgXDJ+ENvVgE=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=KCMkYmrQJpNZM04XeQ6zBXZEf2AK/rMj/xkiSERCQyaEgIElHFzB07LxBiVPm1tzc
         3kc103duv7hL8yjHjr4grD7j15LznrGfsNl0gcw+6mWpQpISYnTiUgRAnLg7XGFNWX
         Kp8aI2EHhnYlGJT+G3skxQ/YfSwVM3soBuMzXx1XzKBtWKFwvwF/0/q5Nm5Tzwth0g
         cQvUwunVeBs1zDKSPnSLGns27WtjxXhx4BlenPBoJaUQl78mJScCN0ENPfL4oz5D1+
         o8za7tOeubfIJm+eiVhzFUSliDpJ+N3lfG/WoF9PqKDH20DcTpjMfi9T54yur4I5x7
         ojCK/S1bdMwUA==
Date:   Tue, 18 Jul 2023 12:11:16 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Kees Cook <kees@kernel.org>
Cc:     justinstitt@google.com, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
        Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH] net: dsa: remove deprecated strncpy
Message-ID: <20230718121116.72267fff@kernel.org>
In-Reply-To: <316E4325-6845-4EFC-AAF8-160622C42144@kernel.org>
References: <20230718-net-dsa-strncpy-v1-1-e84664747713@google.com>
        <316E4325-6845-4EFC-AAF8-160622C42144@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 18 Jul 2023 11:05:23 -0700 Kees Cook wrote:
> Honestly I find the entire get_strings API to be very fragile given
> the lack of passing the length of the buffer, instead depending on
> the string set length lookups in each callback, but refactoring that
> looks like a ton of work for an uncertain benefit.

We have been adding better APIs for long term, and a print helper short
term - ethtool_sprintf(). Should we use ethtool_sprintf() here?