public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: pangzizhen001@208suo.com
Cc: jirislaby@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/tty: Fix typos in comments
Date: Tue, 18 Jul 2023 18:40:03 +0200	[thread overview]
Message-ID: <2023071815-battle-surrender-60e7@gregkh> (raw)
In-Reply-To: <ffa4ee5ba65722fe52481638ab20e068@208suo.com>

On Wed, Jul 19, 2023 at 12:22:25AM +0800, pangzizhen001@208suo.com wrote:
> Delete duplicate word "the"
> 
> Signed-off-by: wangjianli <wangjianli@cdjrlc.com>
> ---
>  drivers/tty/n_gsm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
> index b411a26cc092..e8cd1e07eafe 100644
> --- a/drivers/tty/n_gsm.c
> +++ b/drivers/tty/n_gsm.c
> @@ -1148,7 +1148,7 @@ static void __gsm_data_queue(struct gsm_dlci *dlci,
> struct gsm_msg *msg)
>   *
>   *    Add data to the transmit queue and try and get stuff moving
>   *    out of the mux tty if not already doing so. Take the
> - *    the gsm tx lock and dlci lock.
> + *    gsm tx lock and dlci lock.
>   */
> 
>  static void gsm_data_queue(struct gsm_dlci *dlci, struct gsm_msg *msg)

Please learn how to get involved in kernel development by working in
drivers/staging/* first, as the developers there are used to simple
errors like what you did here, and will work to help you out.

Otherwise, patches like this are just going to cause developers to get
grumpy when you have obvious errors.

good luck!

greg k-h

      parent reply	other threads:[~2023-07-18 16:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230718162025.64358-1-wangjianli@cdjrlc.com>
2023-07-18 16:22 ` [PATCH] drivers/tty: Fix typos in comments pangzizhen001
2023-07-18 16:26   ` pangzizhen001
2023-07-18 16:40   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023071815-battle-surrender-60e7@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pangzizhen001@208suo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox