Re: [PATCH v4 1/4] kernel.h: Split out COUNT_ARGS() and CONCATENATE() to args.h

Andy Shevchenko
2023-08-02T03:19:00Z

On Tue, Aug 01, 2023 at 04:11:39PM -0500, Bjorn Helgaas wrote:
> On Wed, Jul 19, 2023 at 12:11:44AM +0300, Andy Shevchenko wrote:
> > kernel.h is being used as a dump for all kinds of stuff for a long time.
> > The COUNT_ARGS() and CONCATENATE() macros may be used in some places
> > without need of the full kernel.h dependency train with it.
> >
> > Here is the attempt on cleaning it up by splitting out these macros().
> >
> > While at it, include new header where it's being used.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
>
> Acked-by: Bjorn Helgaas <bhelgaas@google.com> # PCI

Thank you!

...

> > -
> > +#include <linux/args.h>
> > #include <linux/mod_devicetable.h>
> >
> > #include <linux/types.h>
>
> If there's not a reason otherwise, I'd put this in the main list
> instead of the weirdly separated mod_devicetable.h.

The idea is to make them alphabetically ordered. currently even main list
is a mess. And I have no idea why mod_devicetable.h is so special, a few
bus headers (e.g., i2c, spi) consider that just as yet another header while
actually ain't using it (in the respective _headers_).

That said, I would take the sorting change as a separate one that can be
done after this.

--
With Best Regards,
Andy Shevchenko