From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] nvmem: core: clear sysfs attributes for each NVMEM device
Date: Tue, 18 Jul 2023 16:43:20 +0200 [thread overview]
Message-ID: <2023071834-sixfold-reggae-0406@gregkh> (raw)
In-Reply-To: <ZLaZ03PzkbPNJQ3b@makrotopia.org>
On Tue, Jul 18, 2023 at 02:55:31PM +0100, Daniel Golle wrote:
> Set nvmem_cells_group.bin_attrs to NULL in case of an NVMEM device not
> having any cells in order to make sure sysfs attributes of a previously
> registered NVMEM device are not accidentally reused for a follow-up
> device which doesn't have any cells.
Wait, attributes and devices should NEVER be reused, how is that
happening here?
And just setting the attribute field to NULL doesn't free or clean up
anything, right? Did memory just leak with this?
confused,
greg k-h
next prev parent reply other threads:[~2023-07-18 14:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 13:55 [PATCH 1/2] nvmem: core: clear sysfs attributes for each NVMEM device Daniel Golle
2023-07-18 14:42 ` Greg Kroah-Hartman
2023-07-18 14:43 ` Greg Kroah-Hartman [this message]
2023-07-18 14:55 ` Srinivas Kandagatla
2023-07-18 15:29 ` Daniel Golle
2023-07-19 8:13 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023071834-sixfold-reggae-0406@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=daniel@makrotopia.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox