From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E547C001DC for ; Wed, 19 Jul 2023 11:42:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229987AbjGSLm1 (ORCPT ); Wed, 19 Jul 2023 07:42:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbjGSLmZ (ORCPT ); Wed, 19 Jul 2023 07:42:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FDA0BE; Wed, 19 Jul 2023 04:42:24 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DA964615BA; Wed, 19 Jul 2023 11:42:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF3D1C433C7; Wed, 19 Jul 2023 11:42:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689766943; bh=wPRMqbpbLUGy3uCjIzFDHysaD/lX8t+s8gaE2CHN+uQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bXWkr6yyQPPbZ1rOXq5/QjUQz1j3giLABh26cCfhh5RRcADgmXpLqKdx6JXnVrscf yTexG6yrL0z1t1ulOjO3C4ZUkqRJsjLO4wJZKDgopoxeqybJzNjsTqWOHqZRKeQVhG RotmvRNeTvtPReViEohETLDXmXSDJChCj4jOmyo9YezWoaKD/l57/0z2mwn7zp+m4s YP0EjW3m3YpKyNqd2l2yV0mlZzN0pjMvgf/sE89lpM0IlLv78rWAhz77VThRdQmWQI yARd2dTevEcb+T6fuoahaUYIvSQ5RbKUoLu+UNDaCb/7BezmnJ9JS4SXlhGzw11ORB ehqFuM01CIKbg== Date: Wed, 19 Jul 2023 17:12:07 +0530 From: Manivannan Sadhasivam To: Vivek Pernamitta Cc: Manivannan Sadhasivam , mhi@lists.linux.dev, mrana@quicinc.com, quic_qianyu@quicinc.com, quic_vbadigan@quicinc.com, quic_krichai@quicinc.com, quic_skananth@quicinc.com, linux-arm-msm@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "open list:NETWORKING DRIVERS" , open list Subject: Re: [PATCH V2] net: mhi : Add support to enable ethernet interface Message-ID: <20230719114207.GC9312@thinkpad> References: <1689660928-12092-1-git-send-email-quic_vpernami@quicinc.com> <20230718124334.GG4771@thinkpad> <350d577a-f0b3-1f20-9c35-356355a9aa8e@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <350d577a-f0b3-1f20-9c35-356355a9aa8e@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 19, 2023 at 04:08:37PM +0530, Vivek Pernamitta wrote: > > Currently MHI NET driver does not support Ethernet interface, > Please do not top post. Read: https://people.kernel.org/tglx/notes-about-netiquette-qw89 > we are adding Ethernet interface support to MHI NET driver, so new client > can be configured to be Ethernet type over MHI by setting > "mhi_device_info.ethernet_if = true" > Which is the new client you are referring to? > currently we are not changing mhi_swip0/mhi_hwip0 to Ethernet. we are adding > an provision to configure mhi client as  Ethernet type. > If there are no users of the said provision, then it should not be added now. You can only add interfaces to kernel if there is atleast one user. - Mani > > On 7/18/2023 6:13 PM, Manivannan Sadhasivam wrote: > > On Tue, Jul 18, 2023 at 11:45:28AM +0530, Vivek Pernamitta wrote: > > > Add support to enable ethernet interface for MHI SWIP channels. > > > > > Please add more info in the commit message i.e., why this interface is added and > > how it is going to benefit the users etc.. > > > > Since you are modifying the existing mhi_swip interface, this isn't an ABI > > change? > > > > > Signed-off-by: Vivek Pernamitta > > > Reviewed-by: Daniele Palmas > > > Reviewed-by: Simon Horman > > > --- > > > > > > changes since v1: > > > - Moved to net-next from linux-next > > > - moved to eth_hw_addr_random() to assign Ethernet MAC address > > > from eth_random_addr() > > > --- > > > drivers/net/mhi_net.c | 53 ++++++++++++++++++++++++++++++++++++++------------- > > > 1 file changed, 40 insertions(+), 13 deletions(-) > > > > > > diff --git a/drivers/net/mhi_net.c b/drivers/net/mhi_net.c > > > index 3d322ac..5bb8d99 100644 > > > --- a/drivers/net/mhi_net.c > > > +++ b/drivers/net/mhi_net.c > > [...] > > > > > @@ -380,10 +405,12 @@ static void mhi_net_remove(struct mhi_device *mhi_dev) > > > static const struct mhi_device_info mhi_hwip0 = { > > > .netname = "mhi_hwip%d", > > > + .ethernet_if = false, > > > }; > > > static const struct mhi_device_info mhi_swip0 = { > > > .netname = "mhi_swip%d", > > > + .ethernet_if = false, > > false? > yes ,it is false as by default mhi_swip/mhi_hwip interface will be normal > net device. > > > > - Mani > > > > > }; > > > static const struct mhi_device_id mhi_net_id_table[] = { > > > -- > > > 2.7.4 > > > -- மணிவண்ணன் சதாசிவம்