From: joeyli <jlee@suse.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Chun-Yi Lee <joeyli.kernel@gmail.com>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Markus Elfring <Markus.Elfring@web.de>,
Dan Carpenter <dan.carpenter@linaro.org>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2] Bluetooth: hci_event: Ignore NULL link key
Date: Wed, 19 Jul 2023 23:38:33 +0800 [thread overview]
Message-ID: <20230719153833.GH14791@linux-l9pv.suse> (raw)
In-Reply-To: <41f91e8e-8038-22d8-baa6-91f98afe405d@molgen.mpg.de>
Hi Paul,
Thanks for your review!
On Tue, Jul 18, 2023 at 07:40:37AM +0200, Paul Menzel wrote:
> Dear Chun-Yi,
>
>
> Thank you for your patch.
>
> Am 18.07.23 um 05:43 schrieb Lee, Chun-Yi <joeyli.kernel@gmail.com>:
>
> […]
>
> > Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
>
> As checkpatch.pl also reports, please make sure the author and Signed-off-by
> entry match.
>
> $ git config --global user.name "Chun-Yi Lee"
> $ git commit --amend --author="Chun-Yi Lee <jlee@suse.com>" -s
>
> (It’s also common to write the name in the order, so no comma is needed.)
>
> `git format-patch` should not generate a patch with a dedicated `From:` at
> the beginning, so you can send it from a different email account. (No idea,
> why upstream Linux kernel development shouldn’t work with your SUSE
> address.)
>
I have set the from in .gitconfig and also tried git send-email --from "Lee, Chun-Yi <jlee@suse.com>".
But gmail always modified it to From: Lee, Chun-Yi <joeyli.kernel@gmail.com>. I have no idea why.
In next version, I will put Signed-off-by: "Lee, Chun-Yi" <joeyli.kernel@gmail.com>
to keep the From: to be sync with Signed-off-by.
Thanks a lot!
Joey Lee
next prev parent reply other threads:[~2023-07-19 15:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-18 3:43 [PATCH v2] Bluetooth: hci_event: Ignore NULL link key Lee, Chun-Yi
2023-07-18 5:40 ` Paul Menzel
2023-07-19 15:38 ` joeyli [this message]
2023-07-19 15:59 ` Dan Carpenter
2023-07-18 17:22 ` Luiz Augusto von Dentz
2023-07-19 15:49 ` joeyli
2023-07-20 0:25 ` Luiz Augusto von Dentz
2023-07-27 22:29 ` Luiz Augusto von Dentz
2023-07-28 14:48 ` joeyli
[not found] ` <79669635-9a07-7fa2-e73e-bf31f554816d@web.de>
2023-07-19 15:40 ` joeyli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230719153833.GH14791@linux-l9pv.suse \
--to=jlee@suse.com \
--cc=Markus.Elfring@web.de \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=joeyli.kernel@gmail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox