Re: [PATCH v2] Bluetooth: hci_event: Ignore NULL link key

joeyli
2023-07-19T15:38:53Z

Hi Paul,

Thanks for your review!

On Tue, Jul 18, 2023 at 07:40:37AM +0200, Paul Menzel wrote:
> Dear Chun-Yi,
>
>
> Thank you for your patch.
>
> Am 18.07.23 um 05:43 schrieb Lee, Chun-Yi <joeyli.kernel@gmail.com>:
>
> […]
>
> > Signed-off-by: "Lee, Chun-Yi" <jlee@suse.com>
>
> As checkpatch.pl also reports, please make sure the author and Signed-off-by
> entry match.
>
> $ git config --global user.name "Chun-Yi Lee"
> $ git commit --amend --author="Chun-Yi Lee <jlee@suse.com>" -s
>
> (It’s also common to write the name in the order, so no comma is needed.)
>
> `git format-patch` should not generate a patch with a dedicated `From:` at
> the beginning, so you can send it from a different email account. (No idea,
> why upstream Linux kernel development shouldn’t work with your SUSE
> address.)
>

I have set the from in .gitconfig and also tried git send-email --from "Lee, Chun-Yi <jlee@suse.com>".
But gmail always modified it to From: Lee, Chun-Yi <joeyli.kernel@gmail.com>. I have no idea why.

In next version, I will put Signed-off-by: "Lee, Chun-Yi" <joeyli.kernel@gmail.com>
to keep the From: to be sync with Signed-off-by.

Thanks a lot!
Joey Lee