* [PATCH -next] drm/amdgpu: Fix one kernel-doc comment
@ 2023-07-20 1:05 Yang Li
2023-07-20 1:26 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Yang Li @ 2023-07-20 1:05 UTC (permalink / raw)
To: alexander.deucher
Cc: airlied, daniel, amd-gfx, dri-devel, linux-kernel, Yang Li
Use colon to separate parameter name from their specific meaning.
silence the warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c:793: warning: Function parameter or member 'adev' not described in 'amdgpu_vm_pte_update_noretry_flags'
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
index 83e1923f6775..96d601e209b8 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
@@ -783,7 +783,7 @@ int amdgpu_vm_pde_update(struct amdgpu_vm_update_params *params,
/**
* amdgpu_vm_pte_update_noretry_flags - Update PTE no-retry flags
*
- * @adev - amdgpu_device pointer
+ * @adev: amdgpu_device pointer
* @flags: pointer to PTE flags
*
* Update PTE no-retry flags when TF is enabled.
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] drm/amdgpu: Fix one kernel-doc comment
2023-07-20 1:05 [PATCH -next] drm/amdgpu: Fix one kernel-doc comment Yang Li
@ 2023-07-20 1:26 ` Randy Dunlap
2023-07-20 16:16 ` Alex Deucher
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2023-07-20 1:26 UTC (permalink / raw)
To: Yang Li, alexander.deucher
Cc: airlied, daniel, amd-gfx, dri-devel, linux-kernel
On 7/19/23 18:05, Yang Li wrote:
> Use colon to separate parameter name from their specific meaning.
> silence the warning:
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c:793: warning: Function parameter or member 'adev' not described in 'amdgpu_vm_pte_update_noretry_flags'
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
> index 83e1923f6775..96d601e209b8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
> @@ -783,7 +783,7 @@ int amdgpu_vm_pde_update(struct amdgpu_vm_update_params *params,
> /**
> * amdgpu_vm_pte_update_noretry_flags - Update PTE no-retry flags
> *
> - * @adev - amdgpu_device pointer
> + * @adev: amdgpu_device pointer
> * @flags: pointer to PTE flags
> *
> * Update PTE no-retry flags when TF is enabled.
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] drm/amdgpu: Fix one kernel-doc comment
2023-07-20 1:26 ` Randy Dunlap
@ 2023-07-20 16:16 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2023-07-20 16:16 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Yang Li, alexander.deucher, dri-devel, amd-gfx, linux-kernel
Applied. Thanks!
On Wed, Jul 19, 2023 at 9:27 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
>
>
> On 7/19/23 18:05, Yang Li wrote:
> > Use colon to separate parameter name from their specific meaning.
> > silence the warning:
> >
> > drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c:793: warning: Function parameter or member 'adev' not described in 'amdgpu_vm_pte_update_noretry_flags'
> >
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>
> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
> Thanks.
>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
> > index 83e1923f6775..96d601e209b8 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c
> > @@ -783,7 +783,7 @@ int amdgpu_vm_pde_update(struct amdgpu_vm_update_params *params,
> > /**
> > * amdgpu_vm_pte_update_noretry_flags - Update PTE no-retry flags
> > *
> > - * @adev - amdgpu_device pointer
> > + * @adev: amdgpu_device pointer
> > * @flags: pointer to PTE flags
> > *
> > * Update PTE no-retry flags when TF is enabled.
>
> --
> ~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH -next] drm/amdgpu: Fix one kernel-doc comment
@ 2023-07-31 3:09 Yang Li
0 siblings, 0 replies; 4+ messages in thread
From: Yang Li @ 2023-07-31 3:09 UTC (permalink / raw)
To: alexander.deucher
Cc: christian.koenig, airlied, daniel, amd-gfx, dri-devel,
linux-kernel, Yang Li, Abaci Robot
Add the description of @xcc_id in amdgpu_mm_wreg_mmio_rlc().
to silence the warning:
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:575: warning: Function parameter or member 'xcc_id' not described in 'amdgpu_mm_wreg_mmio_rlc'
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6031
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index dc0e5227119b..83f52227f9dc 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -566,6 +566,7 @@ void amdgpu_device_wreg(struct amdgpu_device *adev,
* @adev: amdgpu_device pointer
* @reg: mmio/rlc register
* @v: value to write
+ * @xcc_id: index of amdgpu rlc instance
*
* this function is invoked only for the debugfs register access
*/
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-31 3:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-20 1:05 [PATCH -next] drm/amdgpu: Fix one kernel-doc comment Yang Li
2023-07-20 1:26 ` Randy Dunlap
2023-07-20 16:16 ` Alex Deucher
-- strict thread matches above, loose matches on Subject: below --
2023-07-31 3:09 Yang Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox