From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 958D3C04FE0 for ; Thu, 20 Jul 2023 08:58:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231338AbjGTI6H (ORCPT ); Thu, 20 Jul 2023 04:58:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231911AbjGTIe1 (ORCPT ); Thu, 20 Jul 2023 04:34:27 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F8C3268C; Thu, 20 Jul 2023 01:34:27 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 3D3A46732D; Thu, 20 Jul 2023 10:34:23 +0200 (CEST) Date: Thu, 20 Jul 2023 10:34:22 +0200 From: Christoph Hellwig To: Sergey Senozhatsky Cc: Huanpeng Xin , minchan@kernel.org, ngupta@vflare.org, axboe@kernel.dk, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, xinhuanpeng , Christoph Hellwig Subject: Re: [PATCH] zram: set zram bio priority to REQ_PRIO. Message-ID: <20230720083422.GA7112@lst.de> References: <20230718071154.21566-1-xinhuanpeng9@gmail.com> <20230718074929.GD955071@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230718074929.GD955071@google.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org People really need to stop randomly using REQ_PRIO. It was added back then because I did not want to overload REQ_META for WBT priorisation, but it looks other added this somewhat bogus priorisation back anyway. If that is to stay it should probably just go away entirely, but certainly not added for magic boosters for normal data I/O.