From: Alina Yu <alina_yu@richtek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: <lgirdwood@gmail.com>, <broonie@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<alina_yu@richtek.com>
Subject: Re: [PATCH v4 1/2] regulator: dt-bindings: rtq2208: Add Richtek RTQ2208 SubPMIC
Date: Fri, 21 Jul 2023 14:27:35 +0800 [thread overview]
Message-ID: <20230721062735.GA9068@linuxcarl2.richtek.com> (raw)
In-Reply-To: <fd37e408-34d2-8fd3-31b7-b3a07dfb9817@linaro.org>
Hi,
Krzysztof:
> > ...
> >
> >>> +
> >>> + regulator-mode:
> >>> + enum: [0, 1]
> >>> + description:
> >>> + describe buck initial operating mode in suspend state.
> >>
> >> There is no such property on this level. Aren't you mixing initial one?
> >
> > It's the initial mode in suspend-mem state, should I modify that like this ?
> > patternProperties:
> > "^regulator-state-(standby|mem|disk)$":
> > type: object
> > $ref: regulator.yaml#
> > properties:
> > regulator-mode:
> > enum: [0, 1]
> > description:
> > describe byck initial operating mode in suspend state.
>
> Please check how other bindings do it.
>
If I modify that like this, will it be correct ?
...
regulator-state-mem:
type: object
$ref: regulator.yaml#
properties:
regulator-mode:
description:
describe buck initial operating mode in suspend state.
0 - Auto mode
1 - FCCM
Best regards,
Alina
next prev parent reply other threads:[~2023-07-21 6:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 9:24 [PATCH v4 0/2] Add Richtek RTQ2208 SubPMIC support alina_yu
2023-07-19 9:24 ` [PATCH v4 1/2] regulator: dt-bindings: rtq2208: Add Richtek RTQ2208 SubPMIC alina_yu
2023-07-19 9:44 ` Krzysztof Kozlowski
2023-07-20 8:07 ` Alina Yu
2023-07-20 8:38 ` Krzysztof Kozlowski
2023-07-21 6:27 ` Alina Yu [this message]
2023-07-24 2:23 ` Alina Yu
2023-07-19 10:43 ` Rob Herring
2023-07-19 9:24 ` [PATCH v4 2/2] regulator: rtq2208: Add Richtek RTQ2208 SubPMIC driver alina_yu
2023-07-19 17:08 ` Mark Brown
2023-07-20 17:55 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230721062735.GA9068@linuxcarl2.richtek.com \
--to=alina_yu@richtek.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox