From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5679C0015E for ; Fri, 21 Jul 2023 06:28:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229618AbjGUG2k (ORCPT ); Fri, 21 Jul 2023 02:28:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230417AbjGUG2O (ORCPT ); Fri, 21 Jul 2023 02:28:14 -0400 Received: from mg.richtek.com (mg.richtek.com [220.130.44.152]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D2CBD271D; Thu, 20 Jul 2023 23:27:51 -0700 (PDT) X-MailGates: (SIP:2,PASS,NONE)(compute_score:DELIVER,40,3) Received: from 192.168.10.46 by mg.richtek.com with MailGates ESMTPS Server V6.0(2903881:0:AUTH_RELAY) (envelope-from ) (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256/256); Fri, 21 Jul 2023 14:27:35 +0800 (CST) Received: from ex3.rt.l (192.168.10.46) by ex3.rt.l (192.168.10.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.25; Fri, 21 Jul 2023 14:27:35 +0800 Received: from linuxcarl2.richtek.com (192.168.10.154) by ex3.rt.l (192.168.10.45) with Microsoft SMTP Server id 15.2.1118.25 via Frontend Transport; Fri, 21 Jul 2023 14:27:35 +0800 Date: Fri, 21 Jul 2023 14:27:35 +0800 From: Alina Yu To: Krzysztof Kozlowski CC: , , , , , , , Subject: Re: [PATCH v4 1/2] regulator: dt-bindings: rtq2208: Add Richtek RTQ2208 SubPMIC Message-ID: <20230721062735.GA9068@linuxcarl2.richtek.com> References: <1689758686-14409-1-git-send-email-alina_yu@richtek.com> <1689758686-14409-2-git-send-email-alina_yu@richtek.com> <44b50616-a6ee-76e4-21b8-3e39b1a2ccd1@linaro.org> <20230720080728.GA10433@linuxcarl2.richtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Krzysztof: > > ... > > > >>> + > >>> + regulator-mode: > >>> + enum: [0, 1] > >>> + description: > >>> + describe buck initial operating mode in suspend state. > >> > >> There is no such property on this level. Aren't you mixing initial one? > > > > It's the initial mode in suspend-mem state, should I modify that like this ? > > patternProperties: > > "^regulator-state-(standby|mem|disk)$": > > type: object > > $ref: regulator.yaml# > > properties: > > regulator-mode: > > enum: [0, 1] > > description: > > describe byck initial operating mode in suspend state. > > Please check how other bindings do it. > If I modify that like this, will it be correct ? ... regulator-state-mem: type: object $ref: regulator.yaml# properties: regulator-mode: description: describe buck initial operating mode in suspend state. 0 - Auto mode 1 - FCCM Best regards, Alina