From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C9D7C001DC for ; Fri, 21 Jul 2023 07:18:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229675AbjGUHSE (ORCPT ); Fri, 21 Jul 2023 03:18:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229663AbjGUHR4 (ORCPT ); Fri, 21 Jul 2023 03:17:56 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BFC65FC; Fri, 21 Jul 2023 00:17:55 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 2DC71807E; Fri, 21 Jul 2023 07:17:55 +0000 (UTC) Date: Fri, 21 Jul 2023 10:17:53 +0300 From: Tony Lindgren To: Greg Kroah-Hartman Cc: Jiri Slaby , Andy Shevchenko , Andy Shevchenko , Dhruva Gole , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/3] serial: core: Controller id cannot be negative Message-ID: <20230721071753.GR5194@atomide.com> References: <20230720051021.14961-1-tony@atomide.com> <20230720051021.14961-2-tony@atomide.com> <2023072022-country-replace-68ca@gregkh> <20230721054326.GO5194@atomide.com> <2023072144-splurge-debate-e681@gregkh> <20230721061523.GP5194@atomide.com> <20230721065701.GQ5194@atomide.com> <2023072109-fidelity-modular-4074@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2023072109-fidelity-modular-4074@gregkh> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Greg Kroah-Hartman [230721 07:07]: > On Fri, Jul 21, 2023 at 09:57:01AM +0300, Tony Lindgren wrote: > > * Tony Lindgren [230721 06:19]: > > > Looks like linux-serial not getting added is caused by MAINTAINERS > > > not listing serial_base_bus.c, serial_ctrl.c and serial_port.c. This > > > causes get_maintainer.pl to not show linux-serial for a patch touching > > > serial_base_bus.c.. And this will causes git send-email to not pick up > > > linux-serial.. I'll send a patch for MAINTAINERS file too. > > > > And the TTY LAYER is missing the list entries.. Does something like below > > make sense to you guys to include lkml and linux-serial for TTY LAYER? > > > > Regards, > > > > Tony > > > > 8< --------------------- > > diff --git a/MAINTAINERS b/MAINTAINERS > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -21628,11 +21628,17 @@ F: Documentation/translations/zh_TW/ > > TTY LAYER > > M: Greg Kroah-Hartman > > M: Jiri Slaby > > +L: linux-kernel@vger.kernel.org > > +L: linux-serial@vger.kernel.org > > S: Supported > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git > > F: Documentation/driver-api/serial/ > > F: drivers/tty/ > > +F: drivers/tty/serial/serial_base.h > > +F: drivers/tty/serial/serial_base_bus.c > > F: drivers/tty/serial/serial_core.c > > +F: drivers/tty/serial/serial_ctrl.c > > +F: drivers/tty/serial/serial_port.c > > F: include/linux/selection.h > > F: include/linux/serial.h > > F: include/linux/serial_core.h > > -- > > 2.41.0 > > Seems sane to me, I've always wondered why some serial patches didn't > end up on the linux-serial list. OK will send. Also I noticed that using git send-email --cc-cover does not work for the cover letter.. It tries to use the first patch that is the cover letter or something like that. I'm going back to my custom email scripts for now rather than try to have git handle things automagically. Regards, Tony